You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/11/21 07:18:00 UTC

[jira] [Commented] (HDFS-17233) The conf dfs.datanode.lifeline.interval.seconds is not considering time unit seconds

    [ https://issues.apache.org/jira/browse/HDFS-17233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788295#comment-17788295 ] 

ASF GitHub Bot commented on HDFS-17233:
---------------------------------------

eshwitha opened a new pull request, #6286:
URL: https://github.com/apache/hadoop/pull/6286

   …nsidering time unit seconds
   
   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   The configuration dfs.datanode.lifeline.interval.seconds is not considering the time unit as seconds. Upon configuring the  DFS_DATANODE_LIFELINE_INTERVAL_SECONDS_KEY, the value is not converting to Ms as it should be. 
   
   ### How was this patch tested?
   Verified from the datanode logs that the config dfs.datanode.lifeline.interval.seconds is considering the time unit as seconds after the fix.
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   




> The conf dfs.datanode.lifeline.interval.seconds is not considering time unit seconds
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-17233
>                 URL: https://issues.apache.org/jira/browse/HDFS-17233
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>            Reporter: Hemanth Boyina
>            Assignee: Palakur Eshwitha Sai
>            Priority: Major
>
> {code:java}
> long confLifelineIntervalMs =
>     getConf().getLong(DFS_DATANODE_LIFELINE_INTERVAL_SECONDS_KEY,
>     3 * getConf().getTimeDuration(DFS_HEARTBEAT_INTERVAL_KEY,
>     DFS_HEARTBEAT_INTERVAL_DEFAULT, TimeUnit.SECONDS,
>         TimeUnit.MILLISECONDS)); {code}
> if we configure DFS_DATANODE_LIFELINE_INTERVAL_SECONDS_KEY, the value is not converting to Ms. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org