[GitHub] [beam] TheNeuralBit commented on pull request #11554: Website - Migrated Jekyll to Hugo

[GitBox <gi...@apache.org>]

TheNeuralBit commented on pull request #11554:
URL: https://github.com/apache/beam/pull/11554#issuecomment-621489844


   It looks like you first made a bunch of commits that added files to the new directory (e.g. https://github.com/apache/beam/pull/11554/commits/ff7ef26642a9abe148f43d07faf931f69e08333e) and then made one commit that deleted the _entire_ old directory (https://github.com/apache/beam/pull/11554/commits/ee581993c039da3dfbb13b94180956f932ee8498). This means that changes that are effectively just file renames (like all of the blog posts) are not tracked as such, so it looks like a bunch of files were deleted and then re-created - which makes it really hard to review the change.
   
   I _think_ if you just squash all of your commits into one, then git should recognize the files are basically the same, and mark them as renames. More details here: https://stackoverflow.com/questions/433111/how-to-make-git-mark-a-deleted-and-a-new-file-as-a-file-move


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org