You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/03/20 17:29:00 UTC
[jira] [Commented] (GEODE-7863) Reduce Contention on ServerCQImpl
[ https://issues.apache.org/jira/browse/GEODE-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063540#comment-17063540 ]
ASF subversion and git services commented on GEODE-7863:
--------------------------------------------------------
Commit 4ede81abb2393bddbfb0e297cfc7bdfa3fee800b in geode's branch refs/heads/release/1.12.0 from Juan José Ramos
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4ede81a ]
GEODE-7863: Reduce ServerCQImpl Contention (#4798)
We don't need to lock the entire internal cache for Partitioned
regions so the implementation is now split by region type, this will
us to improve/change them independently in the future.
- Removed redundant checks.
- Keep current behavior for Replicate Regions.
- Use ConcurrentMap instead of locking the entire internal cache on
every operation for Partition Regions.
- Keep the lock on ServerCQImpl instance only while executing the
query and leave stats operations outside of the synchronized block.
(cherry picked from commit 9e3c473e9cf6d72126d0e84319b1192a5e2b6fdb)
> Reduce Contention on ServerCQImpl
> ---------------------------------
>
> Key: GEODE-7863
> URL: https://issues.apache.org/jira/browse/GEODE-7863
> Project: Geode
> Issue Type: Bug
> Components: cq
> Reporter: Juan Ramos
> Assignee: Juan Ramos
> Priority: Major
> Labels: GeodeCommons
> Fix For: 1.13.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> While looking at some performance issues recently introduced into {{Geode}} I've noticed that the several methods from the {{ServerCQImpl}} class internally lock an internal {{HashMap}}, it would be better to use a {{ConcurrentMap}} instead.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)