[GitHub] [druid] gianm commented on a diff in pull request #12419: WIP: Optimize add / remove segment and SegmentsCostCache computation

[GitBox <gi...@apache.org>]

gianm commented on code in PR #12419:
URL: https://github.com/apache/druid/pull/12419#discussion_r850511266


##########
core/src/main/java/org/apache/druid/timeline/SegmentId.java:
##########
@@ -266,6 +266,7 @@ public static SegmentId dummy(String dataSource, int partitionNum)
   private final long intervalEndMillis;
   @Nullable
   private final Chronology intervalChronology;
+  private final Interval interval;

Review Comment:
   The comment above mentions that `interval` is not stored, on purpose, in order to reduce heap usage of SegmentId. Presumably that refers to heap usage on Coordinators and Brokers for clusters that have a large number of segments.
   
   Is it important for performance that the interval be cached?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org