You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/10/28 01:58:00 UTC
[jira] [Commented] (KAFKA-9107) Change input Type of
configBackingStore for StandaloneHerder
[ https://issues.apache.org/jira/browse/KAFKA-9107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960719#comment-16960719 ]
ASF GitHub Bot commented on KAFKA-9107:
---------------------------------------
xujianhai666 commented on pull request #7602: KAFKA-9107; Change constructor of StandaloneHerder of test version
URL: https://github.com/apache/kafka/pull/7602
*More detailed description of your change,
Constructor of StandaloneHerder for test version using MemoryConfigBackingStore instead of interface name.
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Change input Type of configBackingStore for StandaloneHerder
> ------------------------------------------------------------
>
> Key: KAFKA-9107
> URL: https://issues.apache.org/jira/browse/KAFKA-9107
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
> Affects Versions: 2.3.0
> Reporter: Xu JianHai
> Priority: Trivial
> Fix For: 2.3.1
>
>
> In method descriptor of StandaloneHerder constructor (Test version), configBackingStore should be ConfigBackingStore instead of MemoryConfigBackingStore.
> I have change and submit pr.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)