You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/02 16:08:25 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new pull request, #22608: Remove useless code in DistSQL.
RaigorJiang opened a new pull request, #22608:
URL: https://github.com/apache/shardingsphere/pull/22608
Changes proposed in this pull request:
- Remove useless parser test in feature DistSQL
- Remove useless defifition in g4
- Fix the name of `showDefaultShardingStrategy`
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #22608: Remove useless code in DistSQL.
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #22608:
URL: https://github.com/apache/shardingsphere/pull/22608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22608: Remove useless code in DistSQL.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22608:
URL: https://github.com/apache/shardingsphere/pull/22608#issuecomment-1335515926
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22608?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22608](https://codecov.io/gh/apache/shardingsphere/pull/22608?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (799e46c) into [master](https://codecov.io/gh/apache/shardingsphere/commit/4fa98fdbddefb47e21e0b23603fcb57b36997eaf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4fa98fd) will **decrease** coverage by `0.20%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #22608 +/- ##
============================================
- Coverage 50.59% 50.39% -0.21%
+ Complexity 2460 2448 -12
============================================
Files 4115 4111 -4
Lines 57616 57596 -20
Branches 9835 9835
============================================
- Hits 29153 29023 -130
- Misses 25953 26074 +121
+ Partials 2510 2499 -11
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22608?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...l/parser/core/ShardingDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/22608/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2Rpc3RzcWwvcGFyc2VyL2NvcmUvU2hhcmRpbmdEaXN0U1FMU3RhdGVtZW50VmlzaXRvci5qYXZh) | `0.00% <ø> (ø)` | |
| [...hadow/distsql/parser/core/ShadowDistSQLParser.java](https://codecov.io/gh/apache/shardingsphere/pull/22608/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2Rpc3RzcWwvcGFyc2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvZGlzdHNxbC9wYXJzZXIvY29yZS9TaGFkb3dEaXN0U1FMUGFyc2VyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rypt/distsql/parser/core/EncryptDistSQLParser.java](https://codecov.io/gh/apache/shardingsphere/pull/22608/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9kaXN0c3FsL3BhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9kaXN0c3FsL3BhcnNlci9jb3JlL0VuY3J5cHREaXN0U1FMUGFyc2VyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ser/facade/ShadowDistSQLStatementParserFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/22608/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2Rpc3RzcWwvcGFyc2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvZGlzdHNxbC9wYXJzZXIvZmFjYWRlL1NoYWRvd0Rpc3RTUUxTdGF0ZW1lbnRQYXJzZXJGYWNhZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/facade/EncryptDistSQLStatementParserFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/22608/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9kaXN0c3FsL3BhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9kaXN0c3FsL3BhcnNlci9mYWNhZGUvRW5jcnlwdERpc3RTUUxTdGF0ZW1lbnRQYXJzZXJGYWNhZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ql/parser/core/DatabaseDiscoveryDistSQLParser.java](https://codecov.io/gh/apache/shardingsphere/pull/22608/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2Rpc3RzcWwvcGFyc2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYmRpc2NvdmVyeS9kaXN0c3FsL3BhcnNlci9jb3JlL0RhdGFiYXNlRGlzY292ZXJ5RGlzdFNRTFBhcnNlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...l/parser/core/ReadwriteSplittingDistSQLParser.java](https://codecov.io/gh/apache/shardingsphere/pull/22608/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvcmVhZHdyaXRlLXNwbGl0dGluZy9kaXN0c3FsL3BhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVhZHdyaXRlc3BsaXR0aW5nL2Rpc3RzcWwvcGFyc2VyL2NvcmUvUmVhZHdyaXRlU3BsaXR0aW5nRGlzdFNRTFBhcnNlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...DatabaseDiscoveryDistSQLStatementParserFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/22608/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2Rpc3RzcWwvcGFyc2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYmRpc2NvdmVyeS9kaXN0c3FsL3BhcnNlci9mYWNhZGUvRGF0YWJhc2VEaXNjb3ZlcnlEaXN0U1FMU3RhdGVtZW50UGFyc2VyRmFjYWRlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...eadwriteSplittingDistSQLStatementParserFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/22608/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvcmVhZHdyaXRlLXNwbGl0dGluZy9kaXN0c3FsL3BhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVhZHdyaXRlc3BsaXR0aW5nL2Rpc3RzcWwvcGFyc2VyL2ZhY2FkZS9SZWFkd3JpdGVTcGxpdHRpbmdEaXN0U1FMU3RhdGVtZW50UGFyc2VyRmFjYWRlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ql/parser/core/EncryptDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/22608/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9kaXN0c3FsL3BhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9kaXN0c3FsL3BhcnNlci9jb3JlL0VuY3J5cHREaXN0U1FMU3RhdGVtZW50VmlzaXRvci5qYXZh) | `0.00% <0.00%> (-73.53%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/shardingsphere/pull/22608/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org