You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/12 10:27:46 UTC

[GitHub] [flink] leonardBang opened a new pull request #14617: [hotfix][doc] Fix default format in document for temporal function FROM_UNIXTIME(numeric, format)

leonardBang opened a new pull request #14617:
URL: https://github.com/apache/flink/pull/14617


   ## What is the purpose of the change
   
   * This pull request to fix doc for temporal function FROM_UNIXTIME(numeric, format), current format is invalid and will mislead users.
   
   
   ## Brief change log
   
     - change format from `YYYY-MM-DD hh:mm:ss` to `yyyy-MM-dd HH:mm:ss`
   
   
   ## Verifying this change
   
   This change is a doc fix without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): ( no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14617: [hotfix][doc] Fix default format in document for temporal function FROM_UNIXTIME(numeric, format)

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14617:
URL: https://github.com/apache/flink/pull/14617#issuecomment-758562289


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 6fda825ac66b34b6e55cb89ad24ea962928e1ef1 (Fri May 28 07:06:29 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14617: [hotfix][doc] Fix default format in document for temporal function FROM_UNIXTIME(numeric, format)

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14617:
URL: https://github.com/apache/flink/pull/14617#issuecomment-758573504


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "090ba49bfd2cc3b452a70d64b1a907e599195e8d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11922",
       "triggerID" : "090ba49bfd2cc3b452a70d64b1a907e599195e8d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6fda825ac66b34b6e55cb89ad24ea962928e1ef1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6fda825ac66b34b6e55cb89ad24ea962928e1ef1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 090ba49bfd2cc3b452a70d64b1a907e599195e8d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11922) 
   * 6fda825ac66b34b6e55cb89ad24ea962928e1ef1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14617: [hotfix][doc] Fix default format in document for temporal function FROM_UNIXTIME(numeric, format)

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14617:
URL: https://github.com/apache/flink/pull/14617#issuecomment-758573504


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "090ba49bfd2cc3b452a70d64b1a907e599195e8d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11922",
       "triggerID" : "090ba49bfd2cc3b452a70d64b1a907e599195e8d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 090ba49bfd2cc3b452a70d64b1a907e599195e8d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11922) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14617: [hotfix][doc] Fix default format in document for temporal function FROM_UNIXTIME(numeric, format)

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14617:
URL: https://github.com/apache/flink/pull/14617#issuecomment-758573504


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "090ba49bfd2cc3b452a70d64b1a907e599195e8d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "090ba49bfd2cc3b452a70d64b1a907e599195e8d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 090ba49bfd2cc3b452a70d64b1a907e599195e8d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14617: [hotfix][doc] Fix default format in document for temporal function FROM_UNIXTIME(numeric, format)

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14617:
URL: https://github.com/apache/flink/pull/14617#issuecomment-758573504


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "090ba49bfd2cc3b452a70d64b1a907e599195e8d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11922",
       "triggerID" : "090ba49bfd2cc3b452a70d64b1a907e599195e8d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6fda825ac66b34b6e55cb89ad24ea962928e1ef1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11960",
       "triggerID" : "6fda825ac66b34b6e55cb89ad24ea962928e1ef1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6fda825ac66b34b6e55cb89ad24ea962928e1ef1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11960) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14617: [hotfix][doc] Fix default format in document for temporal function FROM_UNIXTIME(numeric, format)

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14617:
URL: https://github.com/apache/flink/pull/14617#issuecomment-758562289


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 090ba49bfd2cc3b452a70d64b1a907e599195e8d (Tue Jan 12 10:29:52 UTC 2021)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong merged pull request #14617: [hotfix][doc] Fix default format in document for temporal function FROM_UNIXTIME(numeric, format)

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14617:
URL: https://github.com/apache/flink/pull/14617


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org