You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/07/02 14:58:52 UTC
[GitHub] [sling-org-apache-sling-feature-cpconverter] DominikSuess commented on a change in pull request #88: SLING-10469 - detecting dir folder and substructure belonging to nt f…
DominikSuess commented on a change in pull request #88:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/88#discussion_r663074802
##########
File path: src/main/java/org/apache/sling/feature/cpconverter/handlers/AbstractConfigurationEntryHandler.java
##########
@@ -33,7 +33,7 @@
private boolean enforceConfigurationBelowConfigFolder;
public AbstractConfigurationEntryHandler(@NotNull String extension) {
- super("/jcr_root/(?:apps|libs)/.+/(?<foldername>config|install)(\\.(?<runmode>[^/]+))?/(?<pid>.*)\\." + extension);
+ super("/jcr_root/(?:apps|libs)/.+/(?<foldername>config|install)(\\.(?<runmode>[^/]+))?(.*)/(?<pid>[^\\/]*)\\." + extension + ("(?<dir>.dir(/\\.content\\.xml)?)?$"));
Review comment:
in rebased PR I added a corresponding comment - the groups should explain what I'm trying to capture but inline comments now clarify why we watch for it and why we need to ignore those .dir folders
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org