You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2017/05/09 23:00:27 UTC

[kudu-CR] Make exactly once writes-itest fail fast

David Ribeiro Alves has uploaded a new change for review.

http://gerrit.cloudera.org:8080/6834

Change subject: Make exactly_once_writes-itest fail fast
......................................................................

Make exactly_once_writes-itest fail fast

In this test sometimes a process will crash but the test will
keep running until the timeout spewing messages such as:

...
connection to 127.0.197.0:36258: connect: Connection refused (error 111). Retrying in the next heartbeat period. Already tried 2075 times.
../../src/kudu/integration-tests/ts_itest-base.h:500: Failure
Value of: cluster_->tablet_server(i)->IsProcessAlive()
Actual: false
Expected: true
Tablet server 0 crashed
...

This is because AssertNoTabletServersCrashed() doesn't actually
fail the test.

This patch adds a NO_FATALS to make sure we fail fast in this case,
making failures easier and faster to debug.

All other uses of AssertNoTabletServersCrashed() are wrapped in
NO_FATALS.

Change-Id: Ie77595d906863ea2d41f8df9b93cd6cc27514774
---
M src/kudu/integration-tests/exactly_once_writes-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/6834/1
--
To view, visit http://gerrit.cloudera.org:8080/6834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie77595d906863ea2d41f8df9b93cd6cc27514774
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>

[kudu-CR] Make exactly once writes-itest fail fast

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.

David Ribeiro Alves has submitted this change and it was merged.

Change subject: Make exactly_once_writes-itest fail fast
......................................................................

Make exactly_once_writes-itest fail fast

In this test sometimes a process will crash but the test will
keep running until the timeout spewing messages such as:

This is because AssertNoTabletServersCrashed() doesn't actually
fail the test.

This patch adds a NO_FATALS to make sure we fail fast in this case,
making failures easier and faster to debug.

All other uses of AssertNoTabletServersCrashed() are wrapped in
NO_FATALS.

Change-Id: Ie77595d906863ea2d41f8df9b93cd6cc27514774
Reviewed-on: http://gerrit.cloudera.org:8080/6834
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/exactly_once_writes-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/6834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie77595d906863ea2d41f8df9b93cd6cc27514774
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Make exactly once writes-itest fail fast

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.

Todd Lipcon has posted comments on this change.

Change subject: Make exactly_once_writes-itest fail fast
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie77595d906863ea2d41f8df9b93cd6cc27514774
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No