You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2021/09/18 18:55:15 UTC
[maven] branch master updated: [MNG-7253] Display relocation
message defined in model
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven.git
The following commit(s) were added to refs/heads/master by this push:
new a1ba330 [MNG-7253] Display relocation message defined in model
a1ba330 is described below
commit a1ba33069fad1fb9c6e9cd458ad233ff3a74aadd
Author: George Gastaldi <ge...@gmail.com>
AuthorDate: Fri Sep 17 12:18:27 2021 -0300
[MNG-7253] Display relocation message defined in model
Move logging to DefaultArtifactDescriptorReader
This closes #543
---
.../project/DefaultProjectDependenciesResolver.java | 12 ------------
.../internal/DefaultArtifactDescriptorReader.java | 18 ++++++++++++++++--
2 files changed, 16 insertions(+), 14 deletions(-)
diff --git a/maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java b/maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java
index d6cc080..267dc2d 100644
--- a/maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java
+++ b/maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java
@@ -184,18 +184,6 @@ public class DefaultProjectDependenciesResolver
depRequest.setRoot( node );
- if ( logger.isWarnEnabled() )
- {
- for ( DependencyNode child : node.getChildren() )
- {
- if ( !child.getRelocations().isEmpty() )
- {
- logger.warn( "The artifact " + child.getRelocations().get( 0 ) + " has been relocated to "
- + child.getDependency().getArtifact() );
- }
- }
- }
-
if ( logger.isDebugEnabled() )
{
node.accept( new GraphLogger( project ) );
diff --git a/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java
index eed6f60..af88442 100644
--- a/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java
+++ b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java
@@ -68,6 +68,8 @@ import org.eclipse.aether.resolution.VersionResult;
import org.eclipse.aether.spi.locator.Service;
import org.eclipse.aether.spi.locator.ServiceLocator;
import org.eclipse.aether.transfer.ArtifactNotFoundException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* @author Benjamin Bentmann
@@ -77,6 +79,8 @@ import org.eclipse.aether.transfer.ArtifactNotFoundException;
public class DefaultArtifactDescriptorReader
implements ArtifactDescriptorReader, Service
{
+ private static final Logger LOGGER = LoggerFactory.getLogger( DefaultArtifactDescriptorReader.class );
+
private RemoteRepositoryManager remoteRepositoryManager;
private VersionResolver versionResolver;
@@ -319,10 +323,20 @@ public class DefaultArtifactDescriptorReader
if ( relocation != null )
{
result.addRelocation( a );
- a =
+ Artifact relocatedArtifact =
new RelocatedArtifact( a, relocation.getGroupId(), relocation.getArtifactId(),
relocation.getVersion() );
- result.setArtifact( a );
+ if ( LOGGER.isWarnEnabled() )
+ {
+ String message = "The artifact " + a + " has been relocated to " + relocatedArtifact;
+ if ( relocation.getMessage() != null )
+ {
+ message += ": " + relocation.getMessage();
+ }
+ LOGGER.warn( message );
+ }
+ result.setArtifact( relocatedArtifact );
+ a = relocatedArtifact;
}
else
{