You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/05/16 10:21:00 UTC
[jira] [Commented] (NIFI-11380) Refactor CaptureChangeMySQL with improvements
[ https://issues.apache.org/jira/browse/NIFI-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17723083#comment-17723083 ]
ASF subversion and git services commented on NIFI-11380:
--------------------------------------------------------
Commit 78fd7fadcda5948fe8a7847d2c07f83373c63d1c in nifi's branch refs/heads/main from Matt Burgess
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=78fd7fadcd ]
NIFI-11380: Refactor CaptureChangeMySQL with improvements
This closes #7116
Signed-off-by: Nandor Soma Abonyi <ns...@apache.org>
> Refactor CaptureChangeMySQL with improvements
> ---------------------------------------------
>
> Key: NIFI-11380
> URL: https://issues.apache.org/jira/browse/NIFI-11380
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Matt Burgess
> Assignee: Matt Burgess
> Priority: Major
> Fix For: 1.latest, 2.latest
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The CaptureChangeMySQL processor can be improved in many ways:
> - Eliminate use of DistributedCacheClient
> - MySQLCDCUtils - delete this class. It’s unnecessary. Just put the single method that exists in the parent class of the writers
> - Eliminate mutable member variables. Gather all state together into an object and store that as a single volatile member variable.
> - The outputEvents method is a huge block of switch/case and if/then/else blocks. Kill all of this. Create an interface that’s capable of handling a given event type and have multiple implementations. Determine appropriate impl and call the method.
> - Do not keep a bunch of member variables to “rollback local state”. Keep this in variables. If we fail, no harm, no foul. If we succeed, then update member variable.
> - Remove onStopped method, just annotate stop() method with @OnStopped. No need for @OnShutdown
> - Change name of “hostname” property to "node", and don’t require the port! Default to 3306.
> - Remove unused hasRun member variable
--
This message was sent by Atlassian Jira
(v8.20.10#820010)