[GitHub] [dubbo-go-samples] justxuewei commented on a diff in pull request #523: feat: protobuf v2 integrate test

["justxuewei (via GitHub)" <gi...@apache.org>]

justxuewei commented on code in PR #523:
URL: https://github.com/apache/dubbo-go-samples/pull/523#discussion_r1135217321


##########
tls/triple/go-server/conf/dubbogo.yml:
##########
@@ -9,7 +9,7 @@ dubbo:
         serialization: json
         interface: com.apache.dubbogo.samples.rpc.extension.UserProvider
   tls_config:
-    ca-cert-file: /home/runner/work/dubbo-go-samples/dubbo-go-samples/tls/x509/client_ca_cert.pem
-    tls-cert-file: /home/runner/work/dubbo-go-samples/dubbo-go-samples/tls/x509/server1_cert.pem
-    tls-key-file: /home/runner/work/dubbo-go-samples/dubbo-go-samples/tls/x509/server1_key.pem
+    ca-cert-file: ../../../x509/client_ca_cert.pem
+    tls-cert-file: ../../../x509/server2_cert.pem
+    tls-key-file: ../../../x509/server2_key.pem

Review Comment:
   What is the difference between the server1_key and the server2_key?



##########
start_integrate_test.sh:
##########
@@ -64,13 +64,17 @@ array+=("rpc/triple/msgpack")
 array+=("rpc/triple/pb/dubbogo-grpc")
 array+=("rpc/grpc")
 array+=("rpc/jsonrpc")
+array+=("rpc/triple/pb2")
 
 #tls
 array+=("tls/dubbo")
 array+=("tls/triple")
 array+=("tls/grpc")
 
 
+# replace tls config
+find $(pwd)/tls -type f -print0 | xargs -0 sed -i  's#\.\.\/\.\.\/\.\.#'"$(pwd)/tls"'#g'

Review Comment:
   It is not a good idea to replace all of `../../..` with `$(pwd)/tls`, as this pattern may appear in other files. Therefore, I suggest replacing them one by one with a more specific pattern (including `x509`).
   
   ```bash
   sed -i 's#../../../x509#'"$(pwd)/tls/x509"'#g' tls/dubbo/go-client/conf/dubbogo.yml
   sed -i 's#../../../x509#'"$(pwd)/tls/x509"'#g' tls/dubbo/go-server/conf/dubbogo.yml
   # etc..
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org