You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/17 16:49:24 UTC

[GitHub] [flink] tillrohrmann commented on a change in pull request #10608: [FLINK-15300][Runtime] Fix sanity check to not fail if shuffle memory fraction is out of min/max range

tillrohrmann commented on a change in pull request #10608: [FLINK-15300][Runtime] Fix sanity check to not fail if shuffle memory fraction is out of min/max range
URL: https://github.com/apache/flink/pull/10608#discussion_r358905930
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtilsTest.java
 ##########
 @@ -198,6 +198,35 @@ public void testConfigShuffleMemoryRange() {
 		});
 	}
 
+	@Test
+	public void testSanityCheckShuffleMemoryFractionLessThanMin() {
+		testSanityCheckShuffleMemoryFractionOutOfMinMaxRange(true);
 
 Review comment:
   I'm not a huge fan of boolean parameters. I think it would be better to define an `enum` with values with a more descriptive name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services