[GitHub] [iceberg] nastra commented on a diff in pull request #7569: Core: Add REST API for committing changes against multiple tables

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #7569:
URL: https://github.com/apache/iceberg/pull/7569#discussion_r1229292583


##########
core/src/main/java/org/apache/iceberg/rest/requests/UpdateTableRequest.java:
##########
@@ -35,21 +35,22 @@
 public class UpdateTableRequest implements RESTRequest {
 
   private TableIdentifier identifier;
-  private List<UpdateRequirement> requirements;
+  private List<org.apache.iceberg.UpdateRequirement> requirements;
   private List<MetadataUpdate> updates;
 
   public UpdateTableRequest() {
     // needed for Jackson deserialization
   }
 
-  public UpdateTableRequest(List<UpdateRequirement> requirements, List<MetadataUpdate> updates) {
+  public UpdateTableRequest(
+      List<org.apache.iceberg.UpdateRequirement> requirements, List<MetadataUpdate> updates) {
     this.requirements = requirements;
     this.updates = updates;
   }
 
-  UpdateTableRequest(
+  public UpdateTableRequest(

Review Comment:
   this is required to be public so that it can be used in `RESTSessionCatalog`. 
   It might be also worth adding a Builder to `UpdateTableRequest` so that we don't have to make it public here.
   In this case we have two options:
   * write a manual builder
   * generate a builder from the constructor definition (I've opened https://github.com/apache/iceberg/pull/7838 to indicate how this would look like)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org