You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by thePatmanMI <gi...@git.apache.org> on 2018/09/19 13:57:40 UTC
[GitHub] commons-collections pull request #53: updating containsKey method in Passive...
GitHub user thePatmanMI opened a pull request:
https://github.com/apache/commons-collections/pull/53
updating containsKey method in PassiveExpiringMap
correcting the containsKey method to remove all expired entries to match the class and method javadoc statements
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thePatmanMI/commons-collections patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-collections/pull/53.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #53
----
commit 8a004e019a2fe269431b12ec82824fb372e5380f
Author: thePatmanMI <pa...@...>
Date: 2018-09-19T13:57:06Z
updating containsKey method in PassiveExpiringMap
correcting the containsKey method to remove all expired entries to match the class and method javadoc statements
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-collections issue #53: updating containsKey method in PassiveExpirin...
Posted by thePatmanMI <gi...@git.apache.org>.
Github user thePatmanMI commented on the issue:
https://github.com/apache/commons-collections/pull/53
I can do that. Do you have a preference on whether I should use reflection to access the underlying map(s) (to determine size) or if I should change the underlying map(s) to be package scope instead?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-collections issue #53: updating containsKey method in PassiveExpirin...
Posted by thePatmanMI <gi...@git.apache.org>.
Github user thePatmanMI commented on the issue:
https://github.com/apache/commons-collections/pull/53
are there additional problems with this change, or can it be merged in?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org