You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/04/11 17:24:17 UTC
[GitHub] [pinot] npawar commented on a diff in pull request #8502: Add zk metadata to segment's metadata.properties file
npawar commented on code in PR #8502:
URL: https://github.com/apache/pinot/pull/8502#discussion_r847567661
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/SegmentZKMetadataConfig.java:
##########
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.spi.config.table;
+
+// TODO Possibly redundant class. Use SegmentZKMetadata throughout?
+/**
+ * ZK properties that are to be logged into segment's metadata.properties
+ */
+public class SegmentZKMetadataConfig {
Review Comment:
nit: this class is a bit confusing with the SegmentZkMetadata. How about something specific like RealtimeOffsetConfig or directly pass in startOffset endOffset for now?
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/SegmentZKMetadataConfig.java:
##########
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.spi.config.table;
+
+// TODO Possibly redundant class. Use SegmentZKMetadata throughout?
Review Comment:
that would touch a lot of files, and I don't even think you'll be able to do that without breaking some things along the way. So if at all, attempt that in a separate PR
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/HLRealtimeSegmentDataManager.java:
##########
@@ -285,11 +286,13 @@ public void run() {
_segmentLogger.info("Indexed {} raw events", _realtimeSegment.getNumDocsIndexed());
File tempSegmentFolder = new File(_resourceTmpDir, "tmp-" + System.currentTimeMillis());
+ SegmentZKMetadataConfig segmentZKMetadataConfig = new SegmentZKMetadataConfig();
Review Comment:
you can skip this change for HLC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org