You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/10 19:15:05 UTC

[GitHub] [kafka] MarcoLotz edited a comment on pull request #10091: KAFKA-9524: increase retention time for window and grace periods longer than one day

MarcoLotz edited a comment on pull request #10091:
URL: https://github.com/apache/kafka/pull/10091#issuecomment-776945708


   @vcrfxia Nice one! I performed the suggested the changes. Thanks to your test comments and the fact that now we perform the computation on maintainMs() method, I could change the testing approach to directly test the bug with two lines of code in TimeWindowsTest instead. This preserves the separation of concerns between the tests. Updated the test file.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org