You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "obabichevjb (via GitHub)" <gi...@apache.org> on 2026/08/27 10:58:28 UTC

[PR] fix: Add nullability annotations and fix kotlin-stdlib transitive leak [rocketmq]

obabichevjb opened a new pull request, #10979:
URL: https://github.com/apache/rocketmq/pull/10979

   ### Which Issue(s) This PR Fixes
   
   - [[Enhancement] Add Nullable annotations to nullable Message getters and fix kotlin-stdlib transitive leak #10978](https://github.com/apache/rocketmq/issues/10978)
   
   ### Brief Description
   
   This PR contains two independent fixes:
   
   1. **`@Nullable` annotations on 7 getters in `Message.java`** that can return null at runtime. The methods are declared as returning plain `String`/`Map` with no nullability metadata, which produces silent NPEs in Kotlin consumers and gives no warning in Java IDEs. 
   
   2. **Exclude leaked `kotlin-stdlib` from the `opentelemetry-exporter-otlp` dependency chain**. A pure-Java project depending on `rocketmq-client` transitively resolves `kotlin-stdlib` via: `opentelemetry-exporter-otlp` ā†’ `opentelemetry-exporter-sender-okhttp` ā†’ `okhttp` ā†’ `kotlin-stdlib-*`. Upstream already wrote `kotlin-stdlib` exclusions for the `okio-jvm` edge; this extends them to cover the okhttp path, enforcing a constraint upstream already intended.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: Add nullability annotations and fix kotlin-stdlib transitive leak [rocketmq]

Posted by "obabichevjb (via GitHub) via commits" <co...@rocketmq.apache.org>.
obabichevjb commented on PR #10979:
URL: https://github.com/apache/rocketmq/pull/10979#issuecomment-6576910367

   Is there any chance we could move forward with this PR? If anything is blocking it, Iā€™d be happy to help get it over the finish line.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org