You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2013/05/14 08:46:50 UTC

Review Request: Replaced usage of "Seconds" and "Duration" that represents time with the new "Time". (libprocess)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11143/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Description
-------

See summary. [Part 8 of Duration-Time Refactoring Chain]


Diffs
-----

  third_party/libprocess/include/process/clock.hpp 46b737dcd680a770193dbee9ba2ffd796ec48abd 
  third_party/libprocess/include/process/statistics.hpp 3f56c078d8609041c80c312aa9a42ed24ca42e60 
  third_party/libprocess/include/process/timeout.hpp a907af19c9faa1c87864c5294a8e833bdca60252 
  third_party/libprocess/src/process.cpp 197611fffe1d6f76b011211cf153a41c79c125a1 
  third_party/libprocess/src/statistics.cpp e1fb319eff63e4b7a4c18dba43e4818018b0dd50 
  third_party/libprocess/src/tests/process_tests.cpp 8fbf19676c54eb0da6f8daa042de127608bcb00b 
  third_party/libprocess/src/tests/statistics_tests.cpp d6a53f79c8afe4cccebed2274f3dfdd1fe540d02 

Diff: https://reviews.apache.org/r/11143/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu


Re: Review Request: Replaced usage of "Seconds" and "Duration" that represents time with the new "Time". (libprocess)

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11143/
-----------------------------------------------------------

(Updated May 16, 2013, 8:24 a.m.)


Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Changes
-------

Removed Duration::max() & Duration::min() and replaced their usage with Time::MAX and Time::EPOCH.


Description
-------

See summary. [Part 8 of Duration-Time Refactoring Chain]


Diffs (updated)
-----

  src/slave/monitor.cpp ed62bb50835ddc3fd06964b9f920c7305aaff610 
  third_party/libprocess/include/process/clock.hpp 46b737dcd680a770193dbee9ba2ffd796ec48abd 
  third_party/libprocess/include/process/statistics.hpp 3f56c078d8609041c80c312aa9a42ed24ca42e60 
  third_party/libprocess/include/process/timeout.hpp a907af19c9faa1c87864c5294a8e833bdca60252 
  third_party/libprocess/src/process.cpp edcb684332590f0277bafb2d69de68413fc82828 
  third_party/libprocess/src/statistics.cpp e1fb319eff63e4b7a4c18dba43e4818018b0dd50 
  third_party/libprocess/src/tests/process_tests.cpp 8fbf19676c54eb0da6f8daa042de127608bcb00b 
  third_party/libprocess/src/tests/statistics_tests.cpp d6a53f79c8afe4cccebed2274f3dfdd1fe540d02 
  third_party/libprocess/third_party/stout/include/stout/duration.hpp c943ab196871cf4c55f2a2dce5ef85ffe3a22577 

Diff: https://reviews.apache.org/r/11143/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu