[jira] [Issue Comment Edited] (HBASE-4641) Block cache can be mistakenly instantiated on Master

["Ted Yu (Issue Comment Edited) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138126#comment-13138126 ] 

Ted Yu edited comment on HBASE-4641 at 10/28/11 6:19 PM:
---------------------------------------------------------

Looking at MiniHBaseCluster.init(), we already clone conf and give to each region server:
{code}
      for (int i=0; i<nRegionNodes; i++) {
        Configuration rsConf = HBaseConfiguration.create(conf);
        User user = HBaseTestingUtility.getDifferentUser(rsConf,
            ".hfs."+index++);
        hbaseCluster.addRegionServer(rsConf, i, user);
      }
{code}
Since Configuration object isn't shared by master and region server(s) in minicluster, there is no need to replicate Configuration as patch v1 did.
                
      was (Author: yuzhihong@gmail.com):
    I think the fact that Configuration object may be shared by both master and region server(s) in minicluster poses limitation on this and future tasks.
We should think of changing this sharing which would never happen in production cluster.

Once that is done, there would be no need to replicate Configuration as patch v1 did.
                  
> Block cache can be mistakenly instantiated on Master
> ----------------------------------------------------
>
>                 Key: HBASE-4641
>                 URL: https://issues.apache.org/jira/browse/HBASE-4641
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.92.0, 0.94.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>            Priority: Critical
>             Fix For: 0.92.0
>
>         Attachments: 4641-suggestion-v3.txt, HBASE-4641-v1.patch, HBASE-4641-v2.patch
>
>
> After changes in the block cache instantiation over in HBASE-4422, it looks like the HMaster can now end up with a block cache instantiated.  Not a huge deal but prevents the process from shutting down properly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira