[jira] [Updated] (HBASE-22070) Checking restoreDir in RestoreSnapshotHelper

["Andrew Kyle Purtell (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-22070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kyle Purtell updated HBASE-22070:
----------------------------------------
    Fix Version/s:     (was: 1.5.0)

> Checking restoreDir in RestoreSnapshotHelper 
> ---------------------------------------------
>
>                 Key: HBASE-22070
>                 URL: https://issues.apache.org/jira/browse/HBASE-22070
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 2.0.0
>            Reporter: Vincent Choi
>            Assignee: Vincent Choi
>            Priority: Minor
>             Fix For: 3.0.0, 2.2.0, 1.4.10, 1.3.4, 2.3.0, 2.0.6, 2.1.5
>
>         Attachments: 0001-fixed-a-bug-of-checking-if-restoreDir-is-subDir-of-r.patch, HBASE-22070-master-001.patch, HBASE-22070.patch
>
>
> The restoreDir shouldn't be a sub directory of rootDir. The code check it with a prefix check "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath())". But it goes error in some reasonable cases.
> eg: rootDir = hdfs://user/hbase restoreDir = hdfs://user/hbase_restore. So I think it's more reasonable to chang the code to "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath() + "/" )".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)