[GitHub] [spark] HeartSaVioR commented on a change in pull request #24465: [SPARK-27575][CORE] Yarn file-related confs should merge new value with existing value

[GitBox <gi...@apache.org>]

HeartSaVioR commented on a change in pull request #24465: [SPARK-27575][CORE] Yarn file-related confs should merge new value with existing value
URL: https://github.com/apache/spark/pull/24465#discussion_r278822772
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
 ##########
 @@ -608,7 +612,13 @@ private[spark] class SparkSubmit extends Logging {
           (deployMode & opt.deployMode) != 0 &&
           (clusterManager & opt.clusterManager) != 0) {
         if (opt.clOption != null) { childArgs += (opt.clOption, opt.value) }
 
 Review comment:
   Just curious, I'm not sure that's a valid case, but would it be better to apply the same for `childArgs`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org