You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by el...@apache.org on 2022/01/27 01:05:18 UTC
[superset] 08/12: fix: API logger output (#17981)
This is an automated email from the ASF dual-hosted git repository.
elizabeth pushed a commit to branch 1.4
in repository https://gitbox.apache.org/repos/asf/superset.git
commit d793a7e9497c7415179cbce300a029245ba730a3
Author: Daniel Vaz Gaspar <da...@gmail.com>
AuthorDate: Tue Jan 11 09:30:20 2022 +0000
fix: API logger output (#17981)
* fix: Improve logger messages on core API
* revert package.json change
* fix
* black
* improve log message
* improve message
---
superset/views/core.py | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/superset/views/core.py b/superset/views/core.py
index 148c69d..b21ae58 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -1993,10 +1993,7 @@ class Superset(BaseSupersetView): # pylint: disable=too-many-public-methods
]
DruidCluster = DruidDatasource.cluster_class # pylint: disable=invalid-name
if not user:
- err_msg = __(
- "Can't find User '%(name)s', please ask your admin " "to create one.",
- name=user_name,
- )
+ err_msg = __("Can't find user, please ask your admin to create one.")
logger.error(err_msg, exc_info=True)
return json_error_response(err_msg)
cluster = (
@@ -2005,10 +2002,7 @@ class Superset(BaseSupersetView): # pylint: disable=too-many-public-methods
.one_or_none()
)
if not cluster:
- err_msg = __(
- "Can't find DruidCluster with cluster_name = " "'%(name)s'",
- name=cluster_name,
- )
+ err_msg = __("Can't find DruidCluster")
logger.error(err_msg, exc_info=True)
return json_error_response(err_msg)
try:
@@ -2355,7 +2349,6 @@ class Superset(BaseSupersetView): # pylint: disable=too-many-public-methods
)
def stop_query(self) -> FlaskResponse:
client_id = request.form.get("client_id")
-
query = db.session.query(Query).filter_by(client_id=client_id).one()
if query.status in [
QueryStatus.FAILED,
@@ -2363,9 +2356,7 @@ class Superset(BaseSupersetView): # pylint: disable=too-many-public-methods
QueryStatus.TIMED_OUT,
]:
logger.warning(
- "Query with client_id %s could not be stopped: "
- "query already complete",
- str(client_id),
+ "Query with client_id could not be stopped: query already complete",
)
return self.json_response("OK")