You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Mike Drob <md...@mdrob.com> on 2013/12/12 00:18:24 UTC
Review Request 16196: ACCUMULO-1896
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16196/
-----------------------------------------------------------
Review request for accumulo.
Repository: accumulo
Description
-------
Move .deb generation to a profile so that mvn install works out of the box.
Diffs
-----
README bc469fc
pom.xml 9d33818
Diff: https://reviews.apache.org/r/16196/diff/
Testing
-------
Followed new instructions in the README to build .deb files and then inspected the contents to make sure they are correct.
Thanks,
Mike Drob
Re: Review Request 16196: ACCUMULO-1896
Posted by Mike Drob <md...@mdrob.com>.
> On Dec. 12, 2013, 2:11 a.m., Sean Busbey wrote:
> > pom.xml, lines 315-442
> > <https://reviews.apache.org/r/16196/diff/1/?file=396796#file396796line315>
> >
> > Please leave out the move of unrelated pom sections.
>
> Mike Drob wrote:
> Ugh. No idea why it shows up like that, since those are not the lines moved in the diff at all. It looks like review board decided that when going from ABCDE to ACDBE that CD moved instead of B... Will try uploading a new diff to see if that fixes it.
Nope, couldn't do anything about it. Attaching the raw patch to the JIRA so that somebody can at least look at it that way.
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16196/#review30239
-----------------------------------------------------------
On Dec. 11, 2013, 11:18 p.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16196/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 11:18 p.m.)
>
>
> Review request for accumulo.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Move .deb generation to a profile so that mvn install works out of the box.
>
>
> Diffs
> -----
>
> README bc469fc
> pom.xml 9d33818
>
> Diff: https://reviews.apache.org/r/16196/diff/
>
>
> Testing
> -------
>
> Followed new instructions in the README to build .deb files and then inspected the contents to make sure they are correct.
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 16196: ACCUMULO-1896
Posted by Sean Busbey <se...@manvsbeard.com>.
> On Dec. 12, 2013, 2:11 a.m., Sean Busbey wrote:
> > pom.xml, lines 315-442
> > <https://reviews.apache.org/r/16196/diff/1/?file=396796#file396796line315>
> >
> > Please leave out the move of unrelated pom sections.
>
> Mike Drob wrote:
> Ugh. No idea why it shows up like that, since those are not the lines moved in the diff at all. It looks like review board decided that when going from ABCDE to ACDBE that CD moved instead of B... Will try uploading a new diff to see if that fixes it.
>
> Mike Drob wrote:
> Nope, couldn't do anything about it. Attaching the raw patch to the JIRA so that somebody can at least look at it that way.
Looked at the raw patch on the ticket. fine to resolve.
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16196/#review30239
-----------------------------------------------------------
On Dec. 11, 2013, 11:18 p.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16196/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 11:18 p.m.)
>
>
> Review request for accumulo.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Move .deb generation to a profile so that mvn install works out of the box.
>
>
> Diffs
> -----
>
> README bc469fc
> pom.xml 9d33818
>
> Diff: https://reviews.apache.org/r/16196/diff/
>
>
> Testing
> -------
>
> Followed new instructions in the README to build .deb files and then inspected the contents to make sure they are correct.
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 16196: ACCUMULO-1896
Posted by Mike Drob <md...@mdrob.com>.
> On Dec. 12, 2013, 2:11 a.m., Sean Busbey wrote:
> > pom.xml, lines 315-442
> > <https://reviews.apache.org/r/16196/diff/1/?file=396796#file396796line315>
> >
> > Please leave out the move of unrelated pom sections.
Ugh. No idea why it shows up like that, since those are not the lines moved in the diff at all. It looks like review board decided that when going from ABCDE to ACDBE that CD moved instead of B... Will try uploading a new diff to see if that fixes it.
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16196/#review30239
-----------------------------------------------------------
On Dec. 11, 2013, 11:18 p.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16196/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 11:18 p.m.)
>
>
> Review request for accumulo.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Move .deb generation to a profile so that mvn install works out of the box.
>
>
> Diffs
> -----
>
> README bc469fc
> pom.xml 9d33818
>
> Diff: https://reviews.apache.org/r/16196/diff/
>
>
> Testing
> -------
>
> Followed new instructions in the README to build .deb files and then inspected the contents to make sure they are correct.
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 16196: ACCUMULO-1896
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16196/#review30239
-----------------------------------------------------------
pom.xml
<https://reviews.apache.org/r/16196/#comment57898>
Please leave out the move of unrelated pom sections.
- Sean Busbey
On Dec. 11, 2013, 11:18 p.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16196/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 11:18 p.m.)
>
>
> Review request for accumulo.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Move .deb generation to a profile so that mvn install works out of the box.
>
>
> Diffs
> -----
>
> README bc469fc
> pom.xml 9d33818
>
> Diff: https://reviews.apache.org/r/16196/diff/
>
>
> Testing
> -------
>
> Followed new instructions in the README to build .deb files and then inspected the contents to make sure they are correct.
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 16196: ACCUMULO-1896
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16196/#review30286
-----------------------------------------------------------
Ship it!
Ship It!
- Sean Busbey
On Dec. 11, 2013, 11:18 p.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16196/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 11:18 p.m.)
>
>
> Review request for accumulo.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Move .deb generation to a profile so that mvn install works out of the box.
>
>
> Diffs
> -----
>
> README bc469fc
> pom.xml 9d33818
>
> Diff: https://reviews.apache.org/r/16196/diff/
>
>
> Testing
> -------
>
> Followed new instructions in the README to build .deb files and then inspected the contents to make sure they are correct.
>
>
> Thanks,
>
> Mike Drob
>
>