[GitHub] [spark] andygrove commented on a change in pull request #33624: [SPARK-35881][SQL][FOLLOWUP] Add a boolean flag in AdaptiveSparkPlanExec to ask for columnar output

[GitBox <gi...@apache.org>]

andygrove commented on a change in pull request #33624:
URL: https://github.com/apache/spark/pull/33624#discussion_r682088051



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -65,7 +65,8 @@ case class AdaptiveSparkPlanExec(
     inputPlan: SparkPlan,
     @transient context: AdaptiveExecutionContext,
     @transient preprocessingRules: Seq[Rule[SparkPlan]],
-    @transient isSubquery: Boolean)
+    @transient isSubquery: Boolean,
+    @transient outputColumnar: Boolean = false)

Review comment:
       I like the idea of adding this parameter but I'm not understanding how this would get set to `true`, especially from a Spark plugin.  It looks like new instances of `AdaptiveSparkPlanExec` are only created by the `InsertAdaptiveSparkPlan` rule and that does not explicitly specify a value for `outputColumnar` in this PR. Would a plugin need to replace this rule with a custom version perhaps?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org