You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Rohit Deshpande <ro...@gmail.com> on 2020/11/15 19:53:35 UTC
[VOTE] KIP-680: TopologyTestDriver should not require a Properties argument
Hello all,
I would like to start voting on KIP-680: TopologyTestDriver should not
require a Properties argument.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-680%3A+TopologyTestDriver+should+not+require+a+Properties+argument
Discuss thread:
https://lists.apache.org/thread.html/r5d3d0afc6feb5e18ade47aefbd88534f1b19b2f550a14d33cbc7a0dd%40%3Cdev.kafka.apache.org%3E
Jira for the KIP:
https://issues.apache.org/jira/browse/KAFKA-10629
If we end up making changes, they will look like this:
https://github.com/apache/kafka/compare/trunk...rohitrmd:KAFKA-10629
Thanks,
Rohit
Re: [VOTE] KIP-680: TopologyTestDriver should not require a
Properties argument
Posted by Rohit Deshpande <ro...@gmail.com>.
Hello all,
I am closing the vote as there are 3 binding votes.
Summary of the change:
Proposing to add two new constructors to TopologyTestDriver class.
1. One with only topology as parameter
2. Second one with topology and wall clock time as parameter
Additional condition is we want to set randomized application id in stream
config to avoid conflicts with tests running in parallel.
Wiki for this change: link
<https://cwiki.apache.org/confluence/display/KAFKA/KIP-680%3A+TopologyTestDriver+should+not+require+a+Properties+argument>
Pull request: link <https://github.com/apache/kafka/pull/9660>
Thanks,
Rohit
On Mon, Nov 23, 2020 at 9:58 AM Rohit Deshpande <ro...@gmail.com>
wrote:
> Thanks John and Matthias.
> Waiting for 1 more binding vote.
> Thanks,
> Rohit
>
> On Sat, Nov 21, 2020 at 11:01 AM Matthias J. Sax <mj...@apache.org> wrote:
>
>> +1 (binding)
>>
>> On 11/20/20 7:43 PM, John Roesler wrote:
>> > Thanks again for the KIP, Rohit.
>> >
>> > I’m +1 (binding)
>> >
>> > Sorry, I missed your vote thread.
>> >
>> > -John
>> >
>> > On Fri, Nov 20, 2020, at 21:35, Rohit Deshpande wrote:
>> >> Thanks Guozhang.
>> >> Waiting for binding votes.
>> >> Thanks,
>> >> Rohit
>> >>
>> >> On Tue, Nov 17, 2020 at 10:13 AM Guozhang Wang <wa...@gmail.com>
>> wrote:
>> >>
>> >>> +1, thanks Rohit.
>> >>>
>> >>>
>> >>> Guozhang
>> >>>
>> >>> On Sun, Nov 15, 2020 at 11:53 AM Rohit Deshpande <
>> rohitdeshaws@gmail.com>
>> >>> wrote:
>> >>>
>> >>>> Hello all,
>> >>>> I would like to start voting on KIP-680: TopologyTestDriver should
>> not
>> >>>> require a Properties argument.
>> >>>>
>> >>>>
>> >>>
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-680%3A+TopologyTestDriver+should+not+require+a+Properties+argument
>> >>>>
>> >>>> Discuss thread:
>> >>>>
>> >>>>
>> >>>
>> https://lists.apache.org/thread.html/r5d3d0afc6feb5e18ade47aefbd88534f1b19b2f550a14d33cbc7a0dd%40%3Cdev.kafka.apache.org%3E
>> >>>>
>> >>>> Jira for the KIP:
>> >>>> https://issues.apache.org/jira/browse/KAFKA-10629
>> >>>>
>> >>>> If we end up making changes, they will look like this:
>> >>>> https://github.com/apache/kafka/compare/trunk...rohitrmd:KAFKA-10629
>> >>>>
>> >>>> Thanks,
>> >>>> Rohit
>> >>>>
>> >>>
>> >>>
>> >>> --
>> >>> -- Guozhang
>> >>>
>> >>
>>
>
Re: [VOTE] KIP-680: TopologyTestDriver should not require a
Properties argument
Posted by Rohit Deshpande <ro...@gmail.com>.
Thanks John and Matthias.
Waiting for 1 more binding vote.
Thanks,
Rohit
On Sat, Nov 21, 2020 at 11:01 AM Matthias J. Sax <mj...@apache.org> wrote:
> +1 (binding)
>
> On 11/20/20 7:43 PM, John Roesler wrote:
> > Thanks again for the KIP, Rohit.
> >
> > I’m +1 (binding)
> >
> > Sorry, I missed your vote thread.
> >
> > -John
> >
> > On Fri, Nov 20, 2020, at 21:35, Rohit Deshpande wrote:
> >> Thanks Guozhang.
> >> Waiting for binding votes.
> >> Thanks,
> >> Rohit
> >>
> >> On Tue, Nov 17, 2020 at 10:13 AM Guozhang Wang <wa...@gmail.com>
> wrote:
> >>
> >>> +1, thanks Rohit.
> >>>
> >>>
> >>> Guozhang
> >>>
> >>> On Sun, Nov 15, 2020 at 11:53 AM Rohit Deshpande <
> rohitdeshaws@gmail.com>
> >>> wrote:
> >>>
> >>>> Hello all,
> >>>> I would like to start voting on KIP-680: TopologyTestDriver should not
> >>>> require a Properties argument.
> >>>>
> >>>>
> >>>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-680%3A+TopologyTestDriver+should+not+require+a+Properties+argument
> >>>>
> >>>> Discuss thread:
> >>>>
> >>>>
> >>>
> https://lists.apache.org/thread.html/r5d3d0afc6feb5e18ade47aefbd88534f1b19b2f550a14d33cbc7a0dd%40%3Cdev.kafka.apache.org%3E
> >>>>
> >>>> Jira for the KIP:
> >>>> https://issues.apache.org/jira/browse/KAFKA-10629
> >>>>
> >>>> If we end up making changes, they will look like this:
> >>>> https://github.com/apache/kafka/compare/trunk...rohitrmd:KAFKA-10629
> >>>>
> >>>> Thanks,
> >>>> Rohit
> >>>>
> >>>
> >>>
> >>> --
> >>> -- Guozhang
> >>>
> >>
>
Re: [VOTE] KIP-680: TopologyTestDriver should not require a
Properties argument
Posted by "Matthias J. Sax" <mj...@apache.org>.
+1 (binding)
On 11/20/20 7:43 PM, John Roesler wrote:
> Thanks again for the KIP, Rohit.
>
> I’m +1 (binding)
>
> Sorry, I missed your vote thread.
>
> -John
>
> On Fri, Nov 20, 2020, at 21:35, Rohit Deshpande wrote:
>> Thanks Guozhang.
>> Waiting for binding votes.
>> Thanks,
>> Rohit
>>
>> On Tue, Nov 17, 2020 at 10:13 AM Guozhang Wang <wa...@gmail.com> wrote:
>>
>>> +1, thanks Rohit.
>>>
>>>
>>> Guozhang
>>>
>>> On Sun, Nov 15, 2020 at 11:53 AM Rohit Deshpande <ro...@gmail.com>
>>> wrote:
>>>
>>>> Hello all,
>>>> I would like to start voting on KIP-680: TopologyTestDriver should not
>>>> require a Properties argument.
>>>>
>>>>
>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-680%3A+TopologyTestDriver+should+not+require+a+Properties+argument
>>>>
>>>> Discuss thread:
>>>>
>>>>
>>> https://lists.apache.org/thread.html/r5d3d0afc6feb5e18ade47aefbd88534f1b19b2f550a14d33cbc7a0dd%40%3Cdev.kafka.apache.org%3E
>>>>
>>>> Jira for the KIP:
>>>> https://issues.apache.org/jira/browse/KAFKA-10629
>>>>
>>>> If we end up making changes, they will look like this:
>>>> https://github.com/apache/kafka/compare/trunk...rohitrmd:KAFKA-10629
>>>>
>>>> Thanks,
>>>> Rohit
>>>>
>>>
>>>
>>> --
>>> -- Guozhang
>>>
>>
Re: [VOTE] KIP-680: TopologyTestDriver should not require a Properties argument
Posted by John Roesler <vv...@apache.org>.
Thanks again for the KIP, Rohit.
I’m +1 (binding)
Sorry, I missed your vote thread.
-John
On Fri, Nov 20, 2020, at 21:35, Rohit Deshpande wrote:
> Thanks Guozhang.
> Waiting for binding votes.
> Thanks,
> Rohit
>
> On Tue, Nov 17, 2020 at 10:13 AM Guozhang Wang <wa...@gmail.com> wrote:
>
> > +1, thanks Rohit.
> >
> >
> > Guozhang
> >
> > On Sun, Nov 15, 2020 at 11:53 AM Rohit Deshpande <ro...@gmail.com>
> > wrote:
> >
> > > Hello all,
> > > I would like to start voting on KIP-680: TopologyTestDriver should not
> > > require a Properties argument.
> > >
> > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-680%3A+TopologyTestDriver+should+not+require+a+Properties+argument
> > >
> > > Discuss thread:
> > >
> > >
> > https://lists.apache.org/thread.html/r5d3d0afc6feb5e18ade47aefbd88534f1b19b2f550a14d33cbc7a0dd%40%3Cdev.kafka.apache.org%3E
> > >
> > > Jira for the KIP:
> > > https://issues.apache.org/jira/browse/KAFKA-10629
> > >
> > > If we end up making changes, they will look like this:
> > > https://github.com/apache/kafka/compare/trunk...rohitrmd:KAFKA-10629
> > >
> > > Thanks,
> > > Rohit
> > >
> >
> >
> > --
> > -- Guozhang
> >
>
Re: [VOTE] KIP-680: TopologyTestDriver should not require a
Properties argument
Posted by Rohit Deshpande <ro...@gmail.com>.
Thanks Guozhang.
Waiting for binding votes.
Thanks,
Rohit
On Tue, Nov 17, 2020 at 10:13 AM Guozhang Wang <wa...@gmail.com> wrote:
> +1, thanks Rohit.
>
>
> Guozhang
>
> On Sun, Nov 15, 2020 at 11:53 AM Rohit Deshpande <ro...@gmail.com>
> wrote:
>
> > Hello all,
> > I would like to start voting on KIP-680: TopologyTestDriver should not
> > require a Properties argument.
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-680%3A+TopologyTestDriver+should+not+require+a+Properties+argument
> >
> > Discuss thread:
> >
> >
> https://lists.apache.org/thread.html/r5d3d0afc6feb5e18ade47aefbd88534f1b19b2f550a14d33cbc7a0dd%40%3Cdev.kafka.apache.org%3E
> >
> > Jira for the KIP:
> > https://issues.apache.org/jira/browse/KAFKA-10629
> >
> > If we end up making changes, they will look like this:
> > https://github.com/apache/kafka/compare/trunk...rohitrmd:KAFKA-10629
> >
> > Thanks,
> > Rohit
> >
>
>
> --
> -- Guozhang
>
Re: [VOTE] KIP-680: TopologyTestDriver should not require a
Properties argument
Posted by Guozhang Wang <wa...@gmail.com>.
+1, thanks Rohit.
Guozhang
On Sun, Nov 15, 2020 at 11:53 AM Rohit Deshpande <ro...@gmail.com>
wrote:
> Hello all,
> I would like to start voting on KIP-680: TopologyTestDriver should not
> require a Properties argument.
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-680%3A+TopologyTestDriver+should+not+require+a+Properties+argument
>
> Discuss thread:
>
> https://lists.apache.org/thread.html/r5d3d0afc6feb5e18ade47aefbd88534f1b19b2f550a14d33cbc7a0dd%40%3Cdev.kafka.apache.org%3E
>
> Jira for the KIP:
> https://issues.apache.org/jira/browse/KAFKA-10629
>
> If we end up making changes, they will look like this:
> https://github.com/apache/kafka/compare/trunk...rohitrmd:KAFKA-10629
>
> Thanks,
> Rohit
>
--
-- Guozhang