[jira] Commented: (OFBIZ-402) Convert deprecated minilang operations to the set operation.

["Jacopo Cappellato (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/OFBIZ-402?page=comments#action_12446825 ] 
            
Jacopo Cappellato commented on OFBIZ-402:
-----------------------------------------

Ashish,

thanks for the patches, we really appreciate your work.

In the field-to-env file there was a wrong conversion (DataServices.xml):

-        <field-to-env field-name="userLogin" map-name="parameters" env-name="userLogin"/>
-        <field-to-env field-name="content" map-name="parameters" env-name="currentContent"/>
+        <set field="userLogin" from-field="parameters.userLogin" />
+        <set field="content" from-field="parameters.currentContent" />

The last line should be instead:

+        <set field="currentContent" from-field="parameters.content" />

I've fixed it and everything is committed with rev. 470680

Thanks

PS: it is not necessary to zip the patch files, unless they are very big... you can just attach them to the Jira issues as they are.


> Convert deprecated minilang operations to the set operation.
> ------------------------------------------------------------
>
>                 Key: OFBIZ-402
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-402
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>         Environment: Linux(CentOS) /Windows
>            Reporter: Ashish Vijaywargiya
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: Deprecated_Minilang_Operation_Content.patch.zip, Deprecated_Minilang_Operation_Party.patch.zip, Deprecated_Minilang_Operation_Product.patch.zip, Removed_Deperecated_env-to-env_operation_Nov_03.patch.zip, Removed_Deprecated_field-to-env_operation_Nov_03.patch.zip, Removed_Deprecated_string-to-field_operation_oct_26.patch.zip
>
>
> Hi Jacopo,
> I converted some files to use <set> operation instead of <field-to-field> operation.
> Yesterday I have seen your commit notification and thought that this contribution would reduce your work load.
> I hope it would be helpful.
> At this time I am sending the patch for Product Component and will send you the patch for remaining Party & Content component ASAP.
> Regards
> Ashish Vijaywargiya

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira