You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/14 05:41:05 UTC

[GitHub] [flink] Li-Aihua commented on issue #10378: [FLINK-14919] [flink-end-to-end-perf-tests] Add performance e2e test suite for basic operations

Li-Aihua commented on issue #10378: [FLINK-14919] [flink-end-to-end-perf-tests] Add performance e2e test suite for basic operations
URL: https://github.com/apache/flink/pull/10378#issuecomment-574011447
 
 
   > I'm not convinced that the `PerformanceTestJobBase` is the right approach. Could you expand a bit on the design and why you selected this one?
   > 
   > I'm wondering what the point of all these setters are; do we expect some subclasses to override them?
   > Why are some methods returning values despite them not being used?
   > Why are _all_ methods public despite not being used?
   
   There were some problems with the previous implementation, I updated it again, you can review it again.thanks。

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services