You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "anton-vinogradov (via GitHub)" <gi...@apache.org> on 2023/05/23 15:54:54 UTC
[GitHub] [ignite] anton-vinogradov opened a new pull request, #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
anton-vinogradov opened a new pull request, #10732:
URL: https://github.com/apache/ignite/pull/10732
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #10732:
URL: https://github.com/apache/ignite/pull/10732#discussion_r1206584450
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxStateImpl.java:
##########
@@ -390,9 +369,7 @@ public class IgniteTxStateImpl extends IgniteTxLocalStateAdapter {
/** {@inheritDoc} */
@Override public void onTxEnd(GridCacheSharedContext cctx, IgniteInternalTx tx, boolean commit) {
- for (int i = 0; i < activeCacheIds.size(); i++) {
- int cacheId = activeCacheIds.get(i);
-
+ for (int cacheId : activeCacheIds()) {
Review Comment:
What do you mean by "after"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
Posted by "NSAmelchev (via GitHub)" <gi...@apache.org>.
NSAmelchev commented on code in PR #10732:
URL: https://github.com/apache/ignite/pull/10732#discussion_r1205853977
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxStateImpl.java:
##########
@@ -390,9 +369,7 @@ public class IgniteTxStateImpl extends IgniteTxLocalStateAdapter {
/** {@inheritDoc} */
@Override public void onTxEnd(GridCacheSharedContext cctx, IgniteInternalTx tx, boolean commit) {
- for (int i = 0; i < activeCacheIds.size(); i++) {
- int cacheId = activeCacheIds.get(i);
-
+ for (int cacheId : activeCacheIds()) {
Review Comment:
Can we avoid copying the array after each transaction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #10732:
URL: https://github.com/apache/ignite/pull/10732#discussion_r1209466992
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxStateImpl.java:
##########
@@ -57,51 +57,49 @@
*/
public class IgniteTxStateImpl extends IgniteTxLocalStateAdapter {
/** Active cache IDs. */
- private GridIntList activeCacheIds = new GridIntList();
+ private final GridIntList activeCacheIds = new GridIntList();
/** Per-transaction read map. */
@GridToStringExclude
- protected Map<IgniteTxKey, IgniteTxEntry> txMap;
+ private Map<IgniteTxKey, IgniteTxEntry> txMap;
/** Read view on transaction map. */
@GridToStringExclude
- protected IgniteTxMap readView;
+ private IgniteTxMap readView;
/** Write view on transaction map. */
@GridToStringExclude
- protected IgniteTxMap writeView;
+ private IgniteTxMap writeView;
/** */
@GridToStringInclude
- protected Boolean recovery;
+ private Boolean recovery;
/** */
@GridToStringInclude
- protected Boolean mvccEnabled;
+ private Boolean mvccEnabled;
/** Cache ids used for mvcc caching. See {@link MvccCachingManager}. */
- private GridIntList mvccCachingCacheIds = new GridIntList();
+ private final GridIntList mvccCachingCacheIds = new GridIntList();
/** {@inheritDoc} */
@Override public boolean implicitSingle() {
return false;
}
/** {@inheritDoc} */
- @Nullable @Override public Integer firstCacheId() {
+ @Nullable @Override public synchronized Integer firstCacheId() {
return activeCacheIds.isEmpty() ? null : activeCacheIds.get(0);
}
/** {@inheritDoc} */
- @Nullable @Override public GridIntList cacheIds() {
+ @Nullable @Override public synchronized GridIntList cacheIds() {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ivandasch commented on a diff in pull request #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
Posted by "ivandasch (via GitHub)" <gi...@apache.org>.
ivandasch commented on code in PR #10732:
URL: https://github.com/apache/ignite/pull/10732#discussion_r1206347132
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxStateImpl.java:
##########
@@ -57,51 +57,49 @@
*/
public class IgniteTxStateImpl extends IgniteTxLocalStateAdapter {
/** Active cache IDs. */
- private GridIntList activeCacheIds = new GridIntList();
+ private final GridIntList activeCacheIds = new GridIntList();
/** Per-transaction read map. */
@GridToStringExclude
- protected Map<IgniteTxKey, IgniteTxEntry> txMap;
+ private Map<IgniteTxKey, IgniteTxEntry> txMap;
/** Read view on transaction map. */
@GridToStringExclude
- protected IgniteTxMap readView;
+ private IgniteTxMap readView;
/** Write view on transaction map. */
@GridToStringExclude
- protected IgniteTxMap writeView;
+ private IgniteTxMap writeView;
/** */
@GridToStringInclude
- protected Boolean recovery;
+ private Boolean recovery;
/** */
@GridToStringInclude
- protected Boolean mvccEnabled;
+ private Boolean mvccEnabled;
/** Cache ids used for mvcc caching. See {@link MvccCachingManager}. */
- private GridIntList mvccCachingCacheIds = new GridIntList();
+ private final GridIntList mvccCachingCacheIds = new GridIntList();
/** {@inheritDoc} */
@Override public boolean implicitSingle() {
return false;
}
/** {@inheritDoc} */
- @Nullable @Override public Integer firstCacheId() {
+ @Nullable @Override public synchronized Integer firstCacheId() {
return activeCacheIds.isEmpty() ? null : activeCacheIds.get(0);
}
/** {@inheritDoc} */
- @Nullable @Override public GridIntList cacheIds() {
+ @Nullable @Override public synchronized GridIntList cacheIds() {
Review Comment:
It seems that we should return a copy here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
Posted by "NSAmelchev (via GitHub)" <gi...@apache.org>.
NSAmelchev commented on code in PR #10732:
URL: https://github.com/apache/ignite/pull/10732#discussion_r1206608760
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxStateImpl.java:
##########
@@ -390,9 +369,7 @@ public class IgniteTxStateImpl extends IgniteTxLocalStateAdapter {
/** {@inheritDoc} */
@Override public void onTxEnd(GridCacheSharedContext cctx, IgniteInternalTx tx, boolean commit) {
- for (int i = 0; i < activeCacheIds.size(); i++) {
- int cacheId = activeCacheIds.get(i);
-
+ for (int cacheId : activeCacheIds()) {
Review Comment:
I mean the `onTxEnd` callback. It seems to be called on every tx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #10732:
URL: https://github.com/apache/ignite/pull/10732#discussion_r1206614705
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxStateImpl.java:
##########
@@ -390,9 +369,7 @@ public class IgniteTxStateImpl extends IgniteTxLocalStateAdapter {
/** {@inheritDoc} */
@Override public void onTxEnd(GridCacheSharedContext cctx, IgniteInternalTx tx, boolean commit) {
- for (int i = 0; i < activeCacheIds.size(); i++) {
- int cacheId = activeCacheIds.get(i);
-
+ for (int cacheId : activeCacheIds()) {
Review Comment:
Still not got a problem/proposal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
Posted by "Vladsz83 (via GitHub)" <gi...@apache.org>.
Vladsz83 commented on code in PR #10732:
URL: https://github.com/apache/ignite/pull/10732#discussion_r1205591711
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxStateImpl.java:
##########
@@ -57,51 +57,49 @@
*/
public class IgniteTxStateImpl extends IgniteTxLocalStateAdapter {
/** Active cache IDs. */
- private GridIntList activeCacheIds = new GridIntList();
+ private final GridIntList activeCacheIds = new GridIntList();
/** Per-transaction read map. */
@GridToStringExclude
- protected Map<IgniteTxKey, IgniteTxEntry> txMap;
+ private Map<IgniteTxKey, IgniteTxEntry> txMap;
/** Read view on transaction map. */
@GridToStringExclude
- protected IgniteTxMap readView;
+ private IgniteTxMap readView;
/** Write view on transaction map. */
@GridToStringExclude
- protected IgniteTxMap writeView;
+ private IgniteTxMap writeView;
/** */
@GridToStringInclude
- protected Boolean recovery;
+ private Boolean recovery;
/** */
@GridToStringInclude
- protected Boolean mvccEnabled;
+ private Boolean mvccEnabled;
/** Cache ids used for mvcc caching. See {@link MvccCachingManager}. */
- private GridIntList mvccCachingCacheIds = new GridIntList();
+ private final GridIntList mvccCachingCacheIds = new GridIntList();
/** {@inheritDoc} */
@Override public boolean implicitSingle() {
return false;
}
/** {@inheritDoc} */
- @Nullable @Override public Integer firstCacheId() {
+ @Nullable @Override public synchronized Integer firstCacheId() {
return activeCacheIds.isEmpty() ? null : activeCacheIds.get(0);
}
/** {@inheritDoc} */
- @Nullable @Override public GridIntList cacheIds() {
+ @Nullable @Override public synchronized GridIntList cacheIds() {
Review Comment:
Do we need sync here? activeCacheIds is final
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sonarcloud[bot] commented on pull request #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10732:
URL: https://github.com/apache/ignite/pull/10732#issuecomment-1559746388
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=10732)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
Posted by "NSAmelchev (via GitHub)" <gi...@apache.org>.
NSAmelchev commented on code in PR #10732:
URL: https://github.com/apache/ignite/pull/10732#discussion_r1205841162
##########
modules/core/src/main/java/org/apache/ignite/internal/worker/WorkersRegistry.java:
##########
@@ -229,6 +229,8 @@ public void setSystemWorkerBlockedTimeout(long val) {
"[workerName=" + worker.name() + ", threadName=" + runner.getName() +
", blockedFor=" + heartbeatDelay / 1000 + "s]");
+ U.dumpThreads(log);
Review Comment:
This has already been implemented. See `IGNITE_DUMP_THREADS_ON_FAILURE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #10732:
URL: https://github.com/apache/ignite/pull/10732#discussion_r1206629824
##########
modules/core/src/main/java/org/apache/ignite/internal/worker/WorkersRegistry.java:
##########
@@ -229,6 +229,8 @@ public void setSystemWorkerBlockedTimeout(long val) {
"[workerName=" + worker.name() + ", threadName=" + runner.getName() +
", blockedFor=" + heartbeatDelay / 1000 + "s]");
+ U.dumpThreads(log);
Review Comment:
Yes, but, for some unknown reasons we have the following:
`private Set<FailureType> ignoredFailureTypes =
Collections.unmodifiableSet(EnumSet.of(SYSTEM_WORKER_BLOCKED, SYSTEM_CRITICAL_OPERATION_TIMEOUT));`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sonarcloud[bot] commented on pull request #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10732:
URL: https://github.com/apache/ignite/pull/10732#issuecomment-1582590373
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=10732)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL) [13 Code Smells](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #10732:
URL: https://github.com/apache/ignite/pull/10732#discussion_r1206629824
##########
modules/core/src/main/java/org/apache/ignite/internal/worker/WorkersRegistry.java:
##########
@@ -229,6 +229,8 @@ public void setSystemWorkerBlockedTimeout(long val) {
"[workerName=" + worker.name() + ", threadName=" + runner.getName() +
", blockedFor=" + heartbeatDelay / 1000 + "s]");
+ U.dumpThreads(log);
Review Comment:
Yes, but, for some unknown reasons we have the following:
`private Set<FailureType> ignoredFailureTypes =
Collections.unmodifiableSet(EnumSet.of(SYSTEM_WORKER_BLOCKED, SYSTEM_CRITICAL_OPERATION_TIMEOUT));`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #10732:
URL: https://github.com/apache/ignite/pull/10732#discussion_r1206657342
##########
modules/core/src/main/java/org/apache/ignite/internal/worker/WorkersRegistry.java:
##########
@@ -229,6 +229,8 @@ public void setSystemWorkerBlockedTimeout(long val) {
"[workerName=" + worker.name() + ", threadName=" + runner.getName() +
", blockedFor=" + heartbeatDelay / 1000 + "s]");
+ U.dumpThreads(log);
Review Comment:
This code may not cause the node crash.
And it's execution may happen more than once.
The goal is to write the thread dump each time we have threads blocked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sonarcloud[bot] commented on pull request #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10732:
URL: https://github.com/apache/ignite/pull/10732#issuecomment-1581350975
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=10732)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL) [21 Code Smells](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sonarcloud[bot] commented on pull request #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10732:
URL: https://github.com/apache/ignite/pull/10732#issuecomment-1580771425
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=10732)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sonarcloud[bot] commented on pull request #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10732:
URL: https://github.com/apache/ignite/pull/10732#issuecomment-1581074744
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=10732)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sonarcloud[bot] commented on pull request #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10732:
URL: https://github.com/apache/ignite/pull/10732#issuecomment-1562624062
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=10732)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #10732:
URL: https://github.com/apache/ignite/pull/10732#discussion_r1205697503
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxStateImpl.java:
##########
@@ -57,51 +57,49 @@
*/
public class IgniteTxStateImpl extends IgniteTxLocalStateAdapter {
/** Active cache IDs. */
- private GridIntList activeCacheIds = new GridIntList();
+ private final GridIntList activeCacheIds = new GridIntList();
/** Per-transaction read map. */
@GridToStringExclude
- protected Map<IgniteTxKey, IgniteTxEntry> txMap;
+ private Map<IgniteTxKey, IgniteTxEntry> txMap;
/** Read view on transaction map. */
@GridToStringExclude
- protected IgniteTxMap readView;
+ private IgniteTxMap readView;
/** Write view on transaction map. */
@GridToStringExclude
- protected IgniteTxMap writeView;
+ private IgniteTxMap writeView;
/** */
@GridToStringInclude
- protected Boolean recovery;
+ private Boolean recovery;
/** */
@GridToStringInclude
- protected Boolean mvccEnabled;
+ private Boolean mvccEnabled;
/** Cache ids used for mvcc caching. See {@link MvccCachingManager}. */
- private GridIntList mvccCachingCacheIds = new GridIntList();
+ private final GridIntList mvccCachingCacheIds = new GridIntList();
/** {@inheritDoc} */
@Override public boolean implicitSingle() {
return false;
}
/** {@inheritDoc} */
- @Nullable @Override public Integer firstCacheId() {
+ @Nullable @Override public synchronized Integer firstCacheId() {
return activeCacheIds.isEmpty() ? null : activeCacheIds.get(0);
}
/** {@inheritDoc} */
- @Nullable @Override public GridIntList cacheIds() {
+ @Nullable @Override public synchronized GridIntList cacheIds() {
Review Comment:
The reference is final, but not it's content.
Sync is required to get an actual data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #10732:
URL: https://github.com/apache/ignite/pull/10732#discussion_r1205697503
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxStateImpl.java:
##########
@@ -57,51 +57,49 @@
*/
public class IgniteTxStateImpl extends IgniteTxLocalStateAdapter {
/** Active cache IDs. */
- private GridIntList activeCacheIds = new GridIntList();
+ private final GridIntList activeCacheIds = new GridIntList();
/** Per-transaction read map. */
@GridToStringExclude
- protected Map<IgniteTxKey, IgniteTxEntry> txMap;
+ private Map<IgniteTxKey, IgniteTxEntry> txMap;
/** Read view on transaction map. */
@GridToStringExclude
- protected IgniteTxMap readView;
+ private IgniteTxMap readView;
/** Write view on transaction map. */
@GridToStringExclude
- protected IgniteTxMap writeView;
+ private IgniteTxMap writeView;
/** */
@GridToStringInclude
- protected Boolean recovery;
+ private Boolean recovery;
/** */
@GridToStringInclude
- protected Boolean mvccEnabled;
+ private Boolean mvccEnabled;
/** Cache ids used for mvcc caching. See {@link MvccCachingManager}. */
- private GridIntList mvccCachingCacheIds = new GridIntList();
+ private final GridIntList mvccCachingCacheIds = new GridIntList();
/** {@inheritDoc} */
@Override public boolean implicitSingle() {
return false;
}
/** {@inheritDoc} */
- @Nullable @Override public Integer firstCacheId() {
+ @Nullable @Override public synchronized Integer firstCacheId() {
return activeCacheIds.isEmpty() ? null : activeCacheIds.get(0);
}
/** {@inheritDoc} */
- @Nullable @Override public GridIntList cacheIds() {
+ @Nullable @Override public synchronized GridIntList cacheIds() {
Review Comment:
The reference is final, but not it's content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sonarcloud[bot] commented on pull request #10732: IGNITE-19529 IgniteTxStateImpl's non-thread safe fields may cause incorrect node behavior
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10732:
URL: https://github.com/apache/ignite/pull/10732#issuecomment-1567363543
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=10732)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10732&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10732&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10732&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org