You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2018/04/09 18:28:32 UTC

[GitHub] tinkerpop pull request #834: TINKERPOP-1927 Coerced BulkSet to g:List in Gra...

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/834

    TINKERPOP-1927 Coerced BulkSet to g:List in GraphSON 3.0

    https://issues.apache.org/jira/browse/TINKERPOP-1927
    
    Since GLVs don't have `BulkSet` infrastructure and the need to include it doesn't seem high the most direct fix here is to coerce to `g:List` as the behavior for `BulkSet` iteration is basically that same as a List.
    
    All tests pass with `docker/build.sh -t -i`
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1927

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/834.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #834
    
----
commit 2d6c28a4781786238866bbc942d7706e16ec628e
Author: Stephen Mallette <sp...@...>
Date:   2018-04-05T12:59:56Z

    TINKERPOP-1927 Coerced BulkSet to g:List in GraphSON 3.0
    
    Since GLVs don't have BulkSet infrastructure and the need to include it doesn't seem high the most direct fix here is to coerce to g:List as the behavior for BulkSet iteration is basically that same as a List.

----


---

[GitHub] tinkerpop pull request #834: TINKERPOP-1927 Coerced BulkSet to g:List in Gra...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tinkerpop/pull/834


---

[GitHub] tinkerpop issue #834: TINKERPOP-1927 Coerced BulkSet to g:List in GraphSON 3...

Posted by jorgebay <gi...@git.apache.org>.

Github user jorgebay commented on the issue:

    https://github.com/apache/tinkerpop/pull/834
  
    Great!
    VOTE +1


---

[GitHub] tinkerpop issue #834: TINKERPOP-1927 Coerced BulkSet to g:List in GraphSON 3...

Posted by FlorianHockmann <gi...@git.apache.org>.

Github user FlorianHockmann commented on the issue:

    https://github.com/apache/tinkerpop/pull/834
  
    Nice, no ignored scenarios anymore in Gremlin.Net!
    
    VOTE +1


---