[PR] add lin error flags to lin.h [nuttx]

["wangxiaoxin1 (via GitHub)" <gi...@apache.org>]

wangxiaoxin1 opened a new pull request, #14125:
URL: https://github.com/apache/nuttx/pull/14125

   *Note: Please adhere to [Contributing Guidelines](../CONTRIBUTING.md).*
   
   ## Summary
   To add specific error types about the lin module, first determine the error frame flag, classify the error in data[0], and indicate the specific error in data[1~4]. When there is a problem with the lin module communication, it is convenient to locate the problem in time.
   
   
   ## Impact
   
   *Changes will change the format of lin error frames*
   
   ## Testing
   
   *It has been verified in multiple development versions*
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] add lin error flags to lin.h [nuttx]

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 merged PR #14125:
URL: https://github.com/apache/nuttx/pull/14125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] add lin error flags to lin.h [nuttx]

["nuttxpr (via GitHub)" <gi...@apache.org>]

nuttxpr commented on PR #14125:
URL: https://github.com/apache/nuttx/pull/14125#issuecomment-2407419315

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   The PR summary is reasonably informative, but let's break down whether it meets *all* the NuttX requirements and where it could improve:
   
   **Summary:**
   
   * **✅ Why?**  Clearly states the goal is better error reporting in the LIN module.
   * **✅ What?**  Specifies that the error frame format is being modified.
   * **✅ How?**  Provides a high-level overview of the new format using `data[0]`, `data[1~4]`.
   * **❌ Issue References:**  Missing! These are crucial for linking to bug reports or feature requests.
   * **➕ Could be more specific:**
       * What *exactly* are the new error types? List a few examples.
       * What was the previous error handling like? This helps reviewers understand the improvement.
   
   **Impact:**
   
   * **✅ New Feature?**  Implied, but stating "This PR adds..." is clearer.
   * **❌ User Impact?**  While it changes internal error frames, does this affect how user applications handle LIN errors? Be explicit.
   * **❌ Build Impact?** Unlikely, but stating "NO" explicitly is better.
   * **✅ Hardware Impact:**  "NO" is sufficient if true.
   * **❓ Documentation Impact:**  Does this new error format need to be documented somewhere?
   * **✅ Security Impact:**  "NO" is fine if no vulnerabilities are introduced.
   * **❓ Compatibility Impact:**  Does this break existing applications relying on the old error format?
   * **➕ Anything else?**  This section is for unusual considerations not covered elsewhere.
   
   **Testing:**
   
   * **❌ Build Hosts:**  Provide *specifics*: OS, compiler versions used for testing.
   * **❌ Targets:**  Be *very* specific:  "Multiple development versions" is too vague. List the exact architectures and boards.
   * **❌ Logs:**  Absolutely **require** before/after logs demonstrating the change in error reporting.
   
   **Verdict:**
   
   The PR shows promise but **does NOT fully meet NuttX requirements**.  The missing issue references, vague testing, and incomplete impact assessment need to be addressed before it's ready for review. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org