You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/06 05:40:38 UTC

[GitHub] [arrow] edponce commented on a change in pull request #12084: ARROW-15029: [C++] Split compute/kernels/scalar_string.cc

edponce commented on a change in pull request #12084:
URL: https://github.com/apache/arrow/pull/12084#discussion_r779308490



##########
File path: cpp/src/arrow/CMakeLists.txt
##########
@@ -422,7 +422,9 @@ if(ARROW_COMPUTE)
        compute/kernels/scalar_nested.cc
        compute/kernels/scalar_random.cc
        compute/kernels/scalar_set_lookup.cc
-       compute/kernels/scalar_string.cc
+       compute/kernels/scalar_string_common.cc

Review comment:
       The current convention is to suffix file names with `_internal` when its contents are local common utilities. Based on this, I suggest `scalar_string_common.cc` --> `scalar_string_internal.cc`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org