You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by jo...@apache.org on 2025/01/20 15:23:49 UTC

(sling-org-apache-sling-xss) 01/01: SLING-12622 ensure that Regexp.getPattern() returns non-values

This is an automated email from the ASF dual-hosted git repository.

joerghoh pushed a commit to branch SLING-12622
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-xss.git

commit 8142a518dfefafae668d9e99cda2f76feb9fdb42
Author: Joerg Hoh <jo...@apache.org>
AuthorDate: Mon Jan 20 16:23:35 2025 +0100

    SLING-12622 ensure that Regexp.getPattern() returns non-values
---
 src/test/java/org/apache/sling/xss/impl/xml/PolicyTest.java | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/test/java/org/apache/sling/xss/impl/xml/PolicyTest.java b/src/test/java/org/apache/sling/xss/impl/xml/PolicyTest.java
index b60cefb..0b40dbc 100644
--- a/src/test/java/org/apache/sling/xss/impl/xml/PolicyTest.java
+++ b/src/test/java/org/apache/sling/xss/impl/xml/PolicyTest.java
@@ -70,12 +70,18 @@ class PolicyTest {
             assertEquals(1, dynamic.size(), "number of known dynamic attributes");
             assertEquals(0, closingTag.size(), "number of known closing Tags");
             assertEquals(46, commonAttr.size(), "number of known common attributes");
+
+            // SLING-12622 -- getPattern() must not return null even if no regexp is specified
+            Attribute hrefAttr = commonAttr.get("href");
+            Regexp onsiteUrl = hrefAttr.getRegexpList().get(0);
+            assertEquals("onsiteURL",onsiteUrl.getName());
+            assertNotNull(onsiteUrl.getPattern());
+
             assertEquals(73, tagRules.size(), "number of known tag rules");
             assertEquals(118, cssRules.size(), "number of known css rules");
             assertEquals(12, directives.size(), "number of known directives");
 
             CssPolicy cssPolicy = policy.getCssPolicy();
-
             assertEquals(118, cssPolicy.getCssRules().size(), "cssPolicy.cssRules.size");
             assertTrue(cssPolicy.isValidElementName("base-link"));
             assertFalse(cssPolicy.isValidElementName("base|link"));