You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/17 03:45:40 UTC

[GitHub] [pulsar] nodece opened a new pull request, #17129: [improve][docker] Switch to Temurin JDK

nodece opened a new pull request, #17129:
URL: https://github.com/apache/pulsar/pull/17129

   Signed-off-by: Zixuan Liu <no...@gmail.com>
   
   ### Motivation
   
   I noticed we are using OpenJDK in our Docker image, I suggest that we switch to the Temurin JDK, because our CI runs on the Temurin JDK, we need to keep the same JDK everywhere to avoid unexpected problems.
   
   The Temurin JDK is OpenJDK distribution from Adoptium, the old JDK from Ubuntu, they should all be built on the OpenJDK open source project, and should be fully compatible.
   
   The Temurin JDK is safe and reliable.
   
   > The Eclipse Temurin™ project provides code and processes that support the building of runtime binaries and associated technologies that are high performance, enterprise-caliber, cross-platform, open-source licensed, and Java SE TCK-tested for general use across the Java ecosystem.
   
   https://projects.eclipse.org/projects/adoptium.temurin
   
   If we need to discuss this more, see https://lists.apache.org/thread/t8l4r36vdyo7stkwcml7p1s22f466x8o.
   
   ### Modifications
   
   - Update test image
   - Update build image
   - Update pulsar image
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece commented on pull request #17129: [improve][docker] Switch to Temurin JDK

Posted by GitBox <gi...@apache.org>.
nodece commented on PR #17129:
URL: https://github.com/apache/pulsar/pull/17129#issuecomment-1232547772

   Hi @codelipenghui, @Technoboy- , @michaeljmarshall, @nicoloboschi, @merlimat, @lhotari, and @eolivelli, could you help review this PR? This is a big change for the Pulsar.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #17129: [improve][docker] Switch to Temurin JDK

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on code in PR #17129:
URL: https://github.com/apache/pulsar/pull/17129#discussion_r967674509


##########
docker/pulsar/Dockerfile:
##########
@@ -58,10 +58,20 @@ RUN sed -i "s|http://archive\.ubuntu\.com/ubuntu/|${UBUNTU_MIRROR:-mirror://mirr
      && echo 'Acquire::http::Timeout "30";\nAcquire::ftp::Timeout "30";\nAcquire::Retries "3";' > /etc/apt/apt.conf.d/99timeout_and_retries \
      && apt-get update \
      && apt-get -y dist-upgrade \
-     && apt-get -y install --no-install-recommends openjdk-17-jdk-headless netcat dnsutils less procps iputils-ping \
+     && apt-get -y install --no-install-recommends netcat dnsutils less procps iputils-ping \
                  python3 python3-kazoo python3-pip \
-                 curl ca-certificates \
-     && apt-get -y --purge autoremove \
+                 curl ca-certificates wget apt-transport-https
+
+# Install Eclipse Temurin Package
+RUN mkdir -p /etc/apt/keyrings \
+     && wget -O - https://packages.adoptium.net/artifactory/api/gpg/key/public | tee /etc/apt/keyrings/adoptium.asc \
+     && echo "deb [signed-by=/etc/apt/keyrings/adoptium.asc] https://packages.adoptium.net/artifactory/deb $(awk -F= '/^VERSION_CODENAME/{print$2}' /etc/os-release) main" | tee /etc/apt/sources.list.d/adoptium.list \
+     && apt-get update \
+     && apt-get -y dist-upgrade \
+     && apt-get -y install temurin-17-jdk
+
+# Cleanup apt
+RUN apt-get -y --purge autoremove \

Review Comment:
   Don't we need to run this in the same command that we run our `apt-get` installations in order to get the benefit of a smaller docker image? Otherwise, we'll add files in one layer and remove them in another.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on a diff in pull request #17129: [improve][docker] Switch to Temurin JDK

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17129:
URL: https://github.com/apache/pulsar/pull/17129#discussion_r975065580


##########
docker/pulsar/Dockerfile:
##########
@@ -58,10 +58,20 @@ RUN sed -i "s|http://archive\.ubuntu\.com/ubuntu/|${UBUNTU_MIRROR:-mirror://mirr
      && echo 'Acquire::http::Timeout "30";\nAcquire::ftp::Timeout "30";\nAcquire::Retries "3";' > /etc/apt/apt.conf.d/99timeout_and_retries \
      && apt-get update \
      && apt-get -y dist-upgrade \
-     && apt-get -y install --no-install-recommends openjdk-17-jdk-headless netcat dnsutils less procps iputils-ping \
+     && apt-get -y install --no-install-recommends netcat dnsutils less procps iputils-ping \
                  python3 python3-kazoo python3-pip \
-                 curl ca-certificates \
-     && apt-get -y --purge autoremove \
+                 curl ca-certificates wget apt-transport-https
+
+# Install Eclipse Temurin Package
+RUN mkdir -p /etc/apt/keyrings \
+     && wget -O - https://packages.adoptium.net/artifactory/api/gpg/key/public | tee /etc/apt/keyrings/adoptium.asc \
+     && echo "deb [signed-by=/etc/apt/keyrings/adoptium.asc] https://packages.adoptium.net/artifactory/deb $(awk -F= '/^VERSION_CODENAME/{print$2}' /etc/os-release) main" | tee /etc/apt/sources.list.d/adoptium.list \
+     && apt-get update \
+     && apt-get -y dist-upgrade \
+     && apt-get -y install temurin-17-jdk
+
+# Cleanup apt
+RUN apt-get -y --purge autoremove \

Review Comment:
   Included in https://github.com/apache/pulsar/pull/17733. You can give it a review :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on a diff in pull request #17129: [improve][docker] Switch to Temurin JDK

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17129:
URL: https://github.com/apache/pulsar/pull/17129#discussion_r948613268


##########
docker/pulsar/Dockerfile:
##########
@@ -76,8 +86,8 @@ RUN pip3 install pyyaml==5.4.1
 # 4. /pulsar - hadoop writes to this directory
 RUN mkdir /pulsar && chmod g+w /pulsar
 
-ENV JAVA_HOME /usr/lib/jvm/java-17-openjdk-amd64
-RUN echo networkaddress.cache.ttl=1 >> /usr/lib/jvm/java-17-openjdk-amd64/conf/security/java.security
+ENV JAVA_HOME /usr/lib/jvm/temurin-17-jdk-amd64
+RUN echo networkaddress.cache.ttl=1 >> /usr/lib/jvm/temurin-17-jdk-amd64/conf/security/java.security

Review Comment:
   After add:
   
   ```
   RUN mkdir -p /usr/lib/jvm/java-17-openjdk-amd64/conf/security
   ```
   
   this issue vanished.
   
   I may submit a patch to add it after you migrate openjdk to temurin. `mkdir -p` should not do harm.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece commented on pull request #17129: [improve][docker] Switch to Temurin JDK

Posted by GitBox <gi...@apache.org>.
nodece commented on PR #17129:
URL: https://github.com/apache/pulsar/pull/17129#issuecomment-1223738674

   > Do we have some compatible issues with two different JDKs?
   
   All are based on OpenJDK opensource code, and all should be fully compatible.
   
   > I wonder if it will affect some users who use old JDK and upgrade with new JDK.
   
   Our tests have been using Temurin JDK for some time, so I don't think there is any impact, Temurin JDK will only be more stable.
   
   > And I think this is a big change and may affect the production docker image. We have to notice PMCs approve it.
   
   I agreed with you!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on a diff in pull request #17129: [improve][docker] Switch to Temurin JDK

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17129:
URL: https://github.com/apache/pulsar/pull/17129#discussion_r948616095


##########
docker/pulsar/Dockerfile:
##########
@@ -76,8 +86,8 @@ RUN pip3 install pyyaml==5.4.1
 # 4. /pulsar - hadoop writes to this directory
 RUN mkdir /pulsar && chmod g+w /pulsar
 
-ENV JAVA_HOME /usr/lib/jvm/java-17-openjdk-amd64
-RUN echo networkaddress.cache.ttl=1 >> /usr/lib/jvm/java-17-openjdk-amd64/conf/security/java.security
+ENV JAVA_HOME /usr/lib/jvm/temurin-17-jdk-amd64
+RUN echo networkaddress.cache.ttl=1 >> /usr/lib/jvm/temurin-17-jdk-amd64/conf/security/java.security

Review Comment:
   It seems the first try gives:
   
   ```
   [INFO] DOCKER> deb [signed-by=/etc/apt/keyrings/adoptium.asc] https://packages.adoptium.net/artifactory/deb focal main
   [INFO] DOCKER> Hit:1 http://ports.ubuntu.com/ubuntu-ports focal InRelease
   [INFO] DOCKER> Hit:2 http://ports.ubuntu.com/ubuntu-ports focal-updates InRelease
   [INFO] DOCKER> Hit:3 http://ports.ubuntu.com/ubuntu-ports focal-backports InRelease
   [INFO] DOCKER> Hit:4 http://ports.ubuntu.com/ubuntu-ports focal-security InRelease
   [INFO] DOCKER> Ign:5 https://packages.adoptium.net/artifactory/deb focal InRelease
   [INFO] DOCKER> Err:6 https://packages.adoptium.net/artifactory/deb focal Release
     Could not wait for server fd - select (11: Resource temporarily unavailable) [IP: 198.19.20.71 443]
   [INFO] DOCKER> Reading package lists...
   [INFO] DOCKER> 
   [INFO] DOCKER> [91mE: The repository 'https://packages.adoptium.net/artifactory/deb focal Release' does not have a Release file.
   
   [INFO] DOCKER> Removing intermediate container 322d69692fb0
   [ERROR] DOCKER> Unable to build image [apachepulsar/java-test-image] : "The command '/bin/sh -c mkdir -p /etc/apt/keyrings      && wget -O - https://packages.adoptium.net/artifactory/api/gpg/key/public | tee /etc/apt/keyrings/adoptium.asc      && echo \"deb [signed-by=/etc/apt/keyrings/adoptium.asc] https://packages.adoptium.net/artifactory/deb $(awk -F= '/^VERSION_CODENAME/{print$2}' /etc/os-release) main\" | tee /etc/apt/sources.list.d/adoptium.list      && apt-get update      && apt-get -y dist-upgrade      && apt-get -y install temurin-17-jdk' returned a non-zero code: 100"  ["The command '/bin/sh -c mkdir -p /etc/apt/keyrings      && wget -O - https://packages.adoptium.net/artifactory/api/gpg/key/public | tee /etc/apt/keyrings/adoptium.asc      && echo \"deb [signed-by=/etc/apt/keyrings/adoptium.asc] https://packages.adoptium.net/artifactory/deb $(awk -F= '/^VERSION_CODENAME/{print$2}' /etc/os-release) main\" | tee /etc/apt/sources.list.d/adoptium.list      && apt-get update 
      && apt-get -y dist-upgrade      && apt-get -y install temurin-17-jdk' returned a non-zero code: 100" ]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on pull request #17129: [improve][docker] Switch to Temurin JDK

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17129:
URL: https://github.com/apache/pulsar/pull/17129#issuecomment-1231637546

   FYI - we may try to use [eclipse-temurin/17-focal](https://hub.docker.com/layers/eclipse-temurin/library/eclipse-temurin/17-focal/images/sha256-84607164aa6d21f3b2266cc651ee2bf3a5925b44322831abbe27ce59c339d170?context=explore) image :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on a diff in pull request #17129: [improve][docker] Switch to Temurin JDK

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17129:
URL: https://github.com/apache/pulsar/pull/17129#discussion_r948616095


##########
docker/pulsar/Dockerfile:
##########
@@ -76,8 +86,8 @@ RUN pip3 install pyyaml==5.4.1
 # 4. /pulsar - hadoop writes to this directory
 RUN mkdir /pulsar && chmod g+w /pulsar
 
-ENV JAVA_HOME /usr/lib/jvm/java-17-openjdk-amd64
-RUN echo networkaddress.cache.ttl=1 >> /usr/lib/jvm/java-17-openjdk-amd64/conf/security/java.security
+ENV JAVA_HOME /usr/lib/jvm/temurin-17-jdk-amd64
+RUN echo networkaddress.cache.ttl=1 >> /usr/lib/jvm/temurin-17-jdk-amd64/conf/security/java.security

Review Comment:
   It seems the first try gives:
   
   ```
   [INFO] DOCKER> deb [signed-by=/etc/apt/keyrings/adoptium.asc] https://packages.adoptium.net/artifactory/deb focal main
   [INFO] DOCKER> Hit:1 http://ports.ubuntu.com/ubuntu-ports focal InRelease
   [INFO] DOCKER> Hit:2 http://ports.ubuntu.com/ubuntu-ports focal-updates InRelease
   [INFO] DOCKER> Hit:3 http://ports.ubuntu.com/ubuntu-ports focal-backports InRelease
   [INFO] DOCKER> Hit:4 http://ports.ubuntu.com/ubuntu-ports focal-security InRelease
   [INFO] DOCKER> Ign:5 https://packages.adoptium.net/artifactory/deb focal InRelease
   [INFO] DOCKER> Err:6 https://packages.adoptium.net/artifactory/deb focal Release
     Could not wait for server fd - select (11: Resource temporarily unavailable) [IP: 198.19.20.71 443]
   [INFO] DOCKER> Reading package lists...
   [INFO] DOCKER> 
   [INFO] DOCKER> [91mE: The repository 'https://packages.adoptium.net/artifactory/deb focal Release' does not have a Release file.
   
   [INFO] DOCKER> Removing intermediate container 322d69692fb0
   [ERROR] DOCKER> Unable to build image [apachepulsar/java-test-image] : "The command '/bin/sh -c mkdir -p /etc/apt/keyrings      && wget -O - https://packages.adoptium.net/artifactory/api/gpg/key/public | tee /etc/apt/keyrings/adoptium.asc      && echo \"deb [signed-by=/etc/apt/keyrings/adoptium.asc] https://packages.adoptium.net/artifactory/deb $(awk -F= '/^VERSION_CODENAME/{print$2}' /etc/os-release) main\" | tee /etc/apt/sources.list.d/adoptium.list      && apt-get update      && apt-get -y dist-upgrade      && apt-get -y install temurin-17-jdk' returned a non-zero code: 100"  ["The command '/bin/sh -c mkdir -p /etc/apt/keyrings      && wget -O - https://packages.adoptium.net/artifactory/api/gpg/key/public | tee /etc/apt/keyrings/adoptium.asc      && echo \"deb [signed-by=/etc/apt/keyrings/adoptium.asc] https://packages.adoptium.net/artifactory/deb $(awk -F= '/^VERSION_CODENAME/{print$2}' /etc/os-release) main\" | tee /etc/apt/sources.list.d/adoptium.list      && apt-get update 
      && apt-get -y dist-upgrade      && apt-get -y install temurin-17-jdk' returned a non-zero code: 100" ]
   ```
   
   The command I run: `UBUNTU_MIRROR=http://archive.ubuntu.com/ubuntu/ ./build/build_java_test_image.sh`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on a diff in pull request #17129: [improve][docker] Switch to Temurin JDK

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17129:
URL: https://github.com/apache/pulsar/pull/17129#discussion_r948616095


##########
docker/pulsar/Dockerfile:
##########
@@ -76,8 +86,8 @@ RUN pip3 install pyyaml==5.4.1
 # 4. /pulsar - hadoop writes to this directory
 RUN mkdir /pulsar && chmod g+w /pulsar
 
-ENV JAVA_HOME /usr/lib/jvm/java-17-openjdk-amd64
-RUN echo networkaddress.cache.ttl=1 >> /usr/lib/jvm/java-17-openjdk-amd64/conf/security/java.security
+ENV JAVA_HOME /usr/lib/jvm/temurin-17-jdk-amd64
+RUN echo networkaddress.cache.ttl=1 >> /usr/lib/jvm/temurin-17-jdk-amd64/conf/security/java.security

Review Comment:
   It seems the first try gives:
   
   ```
   [INFO] DOCKER> Step 14/26 : RUN mkdir -p /etc/apt/keyrings      && wget -O - https://packages.adoptium.net/artifactory/api/gpg/key/public | tee /etc/apt/keyrings/adoptium.asc      && echo "deb [signed-by=/etc/apt/keyrings/adoptium.asc] https://packages.adoptium.net/artifactory/deb $(awk -F= '/^VERSION_CODENAME/{print$2}' /etc/os-release) main" | tee /etc/apt/sources.list.d/adoptium.list      && apt-get update      && apt-get -y dist-upgrade      && apt-get -y install temurin-17-jdk
   [INFO] DOCKER> 
   [INFO] DOCKER> ---> Running in 322d69692fb0
   [INFO] DOCKER> [91m--2022-08-18 03:22:25--  https://packages.adoptium.net/artifactory/api/gpg/key/public
   
   [INFO] DOCKER> [91mResolving packages.adoptium.net (packages.adoptium.net)... 
   [INFO] DOCKER> [91m198.19.61.22
   Connecting to packages.adoptium.net (packages.adoptium.net)|198.19.61.22|:443... 
   [INFO] DOCKER> [91mconnected.
   
   [INFO] DOCKER> [91mHTTP request sent, awaiting response... 
   [INFO] DOCKER> [91m200 OK
   Length: unspecified [text/plain]
   Saving to: 'STDOUT'
   
        0K .                                                      3.84M=0s
   
   2022-08-18 03:22:27 (3.84 MB/s) - written to stdout [1793]
   
   
   [INFO] DOCKER> -----BEGIN PGP PUBLIC KEY BLOCK-----
   
   mQENBGGTvTQBCAC6ey144n7CG8foafF6mwgIBN1fIm1ILZDuGS4tMr0/XI8pgJnT
   QvsPxZWEvtSm7bEMObzEoZJcXwjBcJl1B0ui8k5kHMTI75gCmZPsoKLFWIEpuRBQ
   PBocusw80apDmLnNDQLVQvDFtEua5gaNa/fRw9YsmBoXBqvgrjFUIdGyWoQvH5+a
   9OYlWD9n5VV0gnVMb+aclwVzB/zJw3kHGSgzuMtlAHeQiah7Y8yomQn/UIX8yqDf
   +11sP3+c87YcjkRqImRTtmKEDcEtGPAIXC6SYA+uEEkbYE0Fy0chkvtnVWJ597fa
   Epai4rnICU8zoJ6X5z3v1aM2WerhX9oq9X8PABEBAAG0QEFkb3B0aXVtIEdQRyBL
   ZXkgKERFQi9SUE0gU2lnbmluZyBLZXkpIDx0ZW11cmluLWRldkBlY2xpcHNlLm9y
   Zz6JAVIEEwEIADwWIQQ7BNdTyQUNml00PzmEPEilZfjwSwUCYZO9NAIbAwULCQgH
   AgMiAgEGFQoJCAsCBBYCAwECHgcCF4AACgkQhDxIpWX48Et4AggAjjJzYWuKV3nG
   7ngInngl8G/m9JoHr7BmwgcQXYhdy5hVkMcUx5JLeXz2LMBUH/F2nD595hgjMabk
   kVib20X8lq9RsNbdfc2hBcWU6qyHKxsIqT4boI2/XDyEzzMyyZWWNGo/27Ci7Xmj
   pWu31nh0pDdPqdyWDIKojbVVnxlCRY8as8Sm+1ufi709KCi4MuwHNsUlCSwb/fju
   NKeHkrHbLcHKUUIEcmTSKRWrpMYBzm1HYOGBz4xPuELwUfUp71ehfoyBZlp6RDRf
   l5TYI1FmCyHuvjNhrJgWv7bOTcf8yObGY+TEUhzc4xQqCrF4ur9d3opvsuPBQsv+
   Klqi5KSZgrkBDQRhk700AQgAq14okly8cFrpYVenEQPiB75AUZfKRpMduiR6IxAj
   SKcH7aSoFZ9AubUEBVpZsyT5svxoEPe1i4TdbF+m9FGy42EcOlLa3ArLTj5H8FRl
   UdGZB9I5mk4GptOzPM+aHMMu92vW/ZwjuS8DvOiQSp+cUmG1EqOMJSM7e/4BM71z
   E+OKaVJCj79pEzhG3SK/IC/OlxxyETT66NSfYJd7Sw5R6Vr19am/uNU690W0CJ+q
   VQeFpmDMr7LnfdFRIh+lJe05+PvWXeidkGjox5cbG52wf8aRIR/FgkfcFvqRMN1f
   B+dVOWueloUeVAnzcUznOKmUEs7LP9ObJhYHHgup4IAU2wARAQABiQE2BBgBCAAg
   FiEEOwTXU8kFDZpdND85hDxIpWX48EsFAmGTvTQCGwwACgkQhDxIpWX48EvXHQf/
   Q0nZsGDXnZHiBoojeSdpkO7WBjMIP3w1GdLvRpPQrS8TfOPbZuoevzCNh38Y3gwF
   yelJspvzDQrBXhgkzAGlucYg8Y7KHa5Ebm7iDgMzc37L1hYSZTYCqwd7aowfgy34
   hOk3B67LffkJpIh738Oa9CtlwxQ9xcytmBmQ1fBBOwm/9IhAwHPQuydYIs4DxWbj
   0MGSP4fDntU7e4UjsHNmhudDcYol0FaqdHHIIB9C/G4CzetRwHFOn3b4JwXMU7YU
   6aJA3mXhi3hggMC3wkT2HHZ/TquuOdNc02fypWOCDOHz0alBBJNqoVUNFNqU3tfJ
   wI4qF/KKq9BfyfucAs0ykA==
   =szki
   -----END PGP PUBLIC KEY BLOCK-----
   [INFO] DOCKER> deb [signed-by=/etc/apt/keyrings/adoptium.asc] https://packages.adoptium.net/artifactory/deb focal main
   [INFO] DOCKER> Hit:1 http://ports.ubuntu.com/ubuntu-ports focal InRelease
   [INFO] DOCKER> Hit:2 http://ports.ubuntu.com/ubuntu-ports focal-updates InRelease
   [INFO] DOCKER> Hit:3 http://ports.ubuntu.com/ubuntu-ports focal-backports InRelease
   [INFO] DOCKER> Hit:4 http://ports.ubuntu.com/ubuntu-ports focal-security InRelease
   [INFO] DOCKER> Ign:5 https://packages.adoptium.net/artifactory/deb focal InRelease
   [INFO] DOCKER> Err:6 https://packages.adoptium.net/artifactory/deb focal Release
     Could not wait for server fd - select (11: Resource temporarily unavailable) [IP: 198.19.20.71 443]
   [INFO] DOCKER> Reading package lists...
   [INFO] DOCKER> 
   [INFO] DOCKER> [91mE: The repository 'https://packages.adoptium.net/artifactory/deb focal Release' does not have a Release file.
   
   [INFO] DOCKER> Removing intermediate container 322d69692fb0
   [ERROR] DOCKER> Unable to build image [apachepulsar/java-test-image] : "The command '/bin/sh -c mkdir -p /etc/apt/keyrings      && wget -O - https://packages.adoptium.net/artifactory/api/gpg/key/public | tee /etc/apt/keyrings/adoptium.asc      && echo \"deb [signed-by=/etc/apt/keyrings/adoptium.asc] https://packages.adoptium.net/artifactory/deb $(awk -F= '/^VERSION_CODENAME/{print$2}' /etc/os-release) main\" | tee /etc/apt/sources.list.d/adoptium.list      && apt-get update      && apt-get -y dist-upgrade      && apt-get -y install temurin-17-jdk' returned a non-zero code: 100"  ["The command '/bin/sh -c mkdir -p /etc/apt/keyrings      && wget -O - https://packages.adoptium.net/artifactory/api/gpg/key/public | tee /etc/apt/keyrings/adoptium.asc      && echo \"deb [signed-by=/etc/apt/keyrings/adoptium.asc] https://packages.adoptium.net/artifactory/deb $(awk -F= '/^VERSION_CODENAME/{print$2}' /etc/os-release) main\" | tee /etc/apt/sources.list.d/adoptium.list      && apt-get update 
      && apt-get -y dist-upgrade      && apt-get -y install temurin-17-jdk' returned a non-zero code: 100" ]
   ```
   
   The command I run: `UBUNTU_MIRROR=http://archive.ubuntu.com/ubuntu/ ./build/build_java_test_image.sh`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece commented on pull request #17129: [improve][docker] Switch to Temurin JDK

Posted by GitBox <gi...@apache.org>.
nodece commented on PR #17129:
URL: https://github.com/apache/pulsar/pull/17129#issuecomment-1232371888

   > FYI - we may try to use [eclipse-temurin:17-focal](https://hub.docker.com/layers/eclipse-temurin/library/eclipse-temurin/17-focal/images/sha256-84607164aa6d21f3b2266cc651ee2bf3a5925b44322831abbe27ce59c339d170?context=explore) image :)
   
   Using this image looks like a good idea, but there will be a lot of big changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on a diff in pull request #17129: [improve][docker] Switch to Temurin JDK

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17129:
URL: https://github.com/apache/pulsar/pull/17129#discussion_r967678461


##########
docker/pulsar/Dockerfile:
##########
@@ -58,10 +58,20 @@ RUN sed -i "s|http://archive\.ubuntu\.com/ubuntu/|${UBUNTU_MIRROR:-mirror://mirr
      && echo 'Acquire::http::Timeout "30";\nAcquire::ftp::Timeout "30";\nAcquire::Retries "3";' > /etc/apt/apt.conf.d/99timeout_and_retries \
      && apt-get update \
      && apt-get -y dist-upgrade \
-     && apt-get -y install --no-install-recommends openjdk-17-jdk-headless netcat dnsutils less procps iputils-ping \
+     && apt-get -y install --no-install-recommends netcat dnsutils less procps iputils-ping \
                  python3 python3-kazoo python3-pip \
-                 curl ca-certificates \
-     && apt-get -y --purge autoremove \
+                 curl ca-certificates wget apt-transport-https
+
+# Install Eclipse Temurin Package
+RUN mkdir -p /etc/apt/keyrings \
+     && wget -O - https://packages.adoptium.net/artifactory/api/gpg/key/public | tee /etc/apt/keyrings/adoptium.asc \
+     && echo "deb [signed-by=/etc/apt/keyrings/adoptium.asc] https://packages.adoptium.net/artifactory/deb $(awk -F= '/^VERSION_CODENAME/{print$2}' /etc/os-release) main" | tee /etc/apt/sources.list.d/adoptium.list \
+     && apt-get update \
+     && apt-get -y dist-upgrade \
+     && apt-get -y install temurin-17-jdk
+
+# Cleanup apt
+RUN apt-get -y --purge autoremove \

Review Comment:
   Good point. Would you like to prepare a patch and show the difference in size?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on a diff in pull request #17129: [improve][docker] Switch to Temurin JDK

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17129:
URL: https://github.com/apache/pulsar/pull/17129#discussion_r948614135


##########
docker/pulsar/Dockerfile:
##########
@@ -76,8 +86,8 @@ RUN pip3 install pyyaml==5.4.1
 # 4. /pulsar - hadoop writes to this directory
 RUN mkdir /pulsar && chmod g+w /pulsar
 
-ENV JAVA_HOME /usr/lib/jvm/java-17-openjdk-amd64
-RUN echo networkaddress.cache.ttl=1 >> /usr/lib/jvm/java-17-openjdk-amd64/conf/security/java.security
+ENV JAVA_HOME /usr/lib/jvm/temurin-17-jdk-amd64
+RUN echo networkaddress.cache.ttl=1 >> /usr/lib/jvm/temurin-17-jdk-amd64/conf/security/java.security

Review Comment:
   To build docker image on M1, I need a preceding patch (https://github.com/apache/pulsar/pull/17148). You can help with reviewing that patch and I'd like to verify this one integrated with it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on a diff in pull request #17129: [improve][docker] Switch to Temurin JDK

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17129:
URL: https://github.com/apache/pulsar/pull/17129#discussion_r948616095


##########
docker/pulsar/Dockerfile:
##########
@@ -76,8 +86,8 @@ RUN pip3 install pyyaml==5.4.1
 # 4. /pulsar - hadoop writes to this directory
 RUN mkdir /pulsar && chmod g+w /pulsar
 
-ENV JAVA_HOME /usr/lib/jvm/java-17-openjdk-amd64
-RUN echo networkaddress.cache.ttl=1 >> /usr/lib/jvm/java-17-openjdk-amd64/conf/security/java.security
+ENV JAVA_HOME /usr/lib/jvm/temurin-17-jdk-amd64
+RUN echo networkaddress.cache.ttl=1 >> /usr/lib/jvm/temurin-17-jdk-amd64/conf/security/java.security

Review Comment:
   This should be covered by https://github.com/apache/pulsar/issues/12944#issuecomment-1103444708.
   
   <details>
   It seems the first try gives:
   
   ```
   [INFO] DOCKER> Step 14/26 : RUN mkdir -p /etc/apt/keyrings      && wget -O - https://packages.adoptium.net/artifactory/api/gpg/key/public | tee /etc/apt/keyrings/adoptium.asc      && echo "deb [signed-by=/etc/apt/keyrings/adoptium.asc] https://packages.adoptium.net/artifactory/deb $(awk -F= '/^VERSION_CODENAME/{print$2}' /etc/os-release) main" | tee /etc/apt/sources.list.d/adoptium.list      && apt-get update      && apt-get -y dist-upgrade      && apt-get -y install temurin-17-jdk
   [INFO] DOCKER> 
   [INFO] DOCKER> ---> Running in 322d69692fb0
   [INFO] DOCKER> [91m--2022-08-18 03:22:25--  https://packages.adoptium.net/artifactory/api/gpg/key/public
   
   [INFO] DOCKER> [91mResolving packages.adoptium.net (packages.adoptium.net)... 
   [INFO] DOCKER> [91m198.19.61.22
   Connecting to packages.adoptium.net (packages.adoptium.net)|198.19.61.22|:443... 
   [INFO] DOCKER> [91mconnected.
   
   [INFO] DOCKER> [91mHTTP request sent, awaiting response... 
   [INFO] DOCKER> [91m200 OK
   Length: unspecified [text/plain]
   Saving to: 'STDOUT'
   
        0K .                                                      3.84M=0s
   
   2022-08-18 03:22:27 (3.84 MB/s) - written to stdout [1793]
   
   
   [INFO] DOCKER> -----BEGIN PGP PUBLIC KEY BLOCK-----
   
   mQENBGGTvTQBCAC6ey144n7CG8foafF6mwgIBN1fIm1ILZDuGS4tMr0/XI8pgJnT
   QvsPxZWEvtSm7bEMObzEoZJcXwjBcJl1B0ui8k5kHMTI75gCmZPsoKLFWIEpuRBQ
   PBocusw80apDmLnNDQLVQvDFtEua5gaNa/fRw9YsmBoXBqvgrjFUIdGyWoQvH5+a
   9OYlWD9n5VV0gnVMb+aclwVzB/zJw3kHGSgzuMtlAHeQiah7Y8yomQn/UIX8yqDf
   +11sP3+c87YcjkRqImRTtmKEDcEtGPAIXC6SYA+uEEkbYE0Fy0chkvtnVWJ597fa
   Epai4rnICU8zoJ6X5z3v1aM2WerhX9oq9X8PABEBAAG0QEFkb3B0aXVtIEdQRyBL
   ZXkgKERFQi9SUE0gU2lnbmluZyBLZXkpIDx0ZW11cmluLWRldkBlY2xpcHNlLm9y
   Zz6JAVIEEwEIADwWIQQ7BNdTyQUNml00PzmEPEilZfjwSwUCYZO9NAIbAwULCQgH
   AgMiAgEGFQoJCAsCBBYCAwECHgcCF4AACgkQhDxIpWX48Et4AggAjjJzYWuKV3nG
   7ngInngl8G/m9JoHr7BmwgcQXYhdy5hVkMcUx5JLeXz2LMBUH/F2nD595hgjMabk
   kVib20X8lq9RsNbdfc2hBcWU6qyHKxsIqT4boI2/XDyEzzMyyZWWNGo/27Ci7Xmj
   pWu31nh0pDdPqdyWDIKojbVVnxlCRY8as8Sm+1ufi709KCi4MuwHNsUlCSwb/fju
   NKeHkrHbLcHKUUIEcmTSKRWrpMYBzm1HYOGBz4xPuELwUfUp71ehfoyBZlp6RDRf
   l5TYI1FmCyHuvjNhrJgWv7bOTcf8yObGY+TEUhzc4xQqCrF4ur9d3opvsuPBQsv+
   Klqi5KSZgrkBDQRhk700AQgAq14okly8cFrpYVenEQPiB75AUZfKRpMduiR6IxAj
   SKcH7aSoFZ9AubUEBVpZsyT5svxoEPe1i4TdbF+m9FGy42EcOlLa3ArLTj5H8FRl
   UdGZB9I5mk4GptOzPM+aHMMu92vW/ZwjuS8DvOiQSp+cUmG1EqOMJSM7e/4BM71z
   E+OKaVJCj79pEzhG3SK/IC/OlxxyETT66NSfYJd7Sw5R6Vr19am/uNU690W0CJ+q
   VQeFpmDMr7LnfdFRIh+lJe05+PvWXeidkGjox5cbG52wf8aRIR/FgkfcFvqRMN1f
   B+dVOWueloUeVAnzcUznOKmUEs7LP9ObJhYHHgup4IAU2wARAQABiQE2BBgBCAAg
   FiEEOwTXU8kFDZpdND85hDxIpWX48EsFAmGTvTQCGwwACgkQhDxIpWX48EvXHQf/
   Q0nZsGDXnZHiBoojeSdpkO7WBjMIP3w1GdLvRpPQrS8TfOPbZuoevzCNh38Y3gwF
   yelJspvzDQrBXhgkzAGlucYg8Y7KHa5Ebm7iDgMzc37L1hYSZTYCqwd7aowfgy34
   hOk3B67LffkJpIh738Oa9CtlwxQ9xcytmBmQ1fBBOwm/9IhAwHPQuydYIs4DxWbj
   0MGSP4fDntU7e4UjsHNmhudDcYol0FaqdHHIIB9C/G4CzetRwHFOn3b4JwXMU7YU
   6aJA3mXhi3hggMC3wkT2HHZ/TquuOdNc02fypWOCDOHz0alBBJNqoVUNFNqU3tfJ
   wI4qF/KKq9BfyfucAs0ykA==
   =szki
   -----END PGP PUBLIC KEY BLOCK-----
   [INFO] DOCKER> deb [signed-by=/etc/apt/keyrings/adoptium.asc] https://packages.adoptium.net/artifactory/deb focal main
   [INFO] DOCKER> Hit:1 http://ports.ubuntu.com/ubuntu-ports focal InRelease
   [INFO] DOCKER> Hit:2 http://ports.ubuntu.com/ubuntu-ports focal-updates InRelease
   [INFO] DOCKER> Hit:3 http://ports.ubuntu.com/ubuntu-ports focal-backports InRelease
   [INFO] DOCKER> Hit:4 http://ports.ubuntu.com/ubuntu-ports focal-security InRelease
   [INFO] DOCKER> Ign:5 https://packages.adoptium.net/artifactory/deb focal InRelease
   [INFO] DOCKER> Err:6 https://packages.adoptium.net/artifactory/deb focal Release
     Could not wait for server fd - select (11: Resource temporarily unavailable) [IP: 198.19.20.71 443]
   [INFO] DOCKER> Reading package lists...
   [INFO] DOCKER> 
   [INFO] DOCKER> [91mE: The repository 'https://packages.adoptium.net/artifactory/deb focal Release' does not have a Release file.
   
   [INFO] DOCKER> Removing intermediate container 322d69692fb0
   [ERROR] DOCKER> Unable to build image [apachepulsar/java-test-image] : "The command '/bin/sh -c mkdir -p /etc/apt/keyrings      && wget -O - https://packages.adoptium.net/artifactory/api/gpg/key/public | tee /etc/apt/keyrings/adoptium.asc      && echo \"deb [signed-by=/etc/apt/keyrings/adoptium.asc] https://packages.adoptium.net/artifactory/deb $(awk -F= '/^VERSION_CODENAME/{print$2}' /etc/os-release) main\" | tee /etc/apt/sources.list.d/adoptium.list      && apt-get update      && apt-get -y dist-upgrade      && apt-get -y install temurin-17-jdk' returned a non-zero code: 100"  ["The command '/bin/sh -c mkdir -p /etc/apt/keyrings      && wget -O - https://packages.adoptium.net/artifactory/api/gpg/key/public | tee /etc/apt/keyrings/adoptium.asc      && echo \"deb [signed-by=/etc/apt/keyrings/adoptium.asc] https://packages.adoptium.net/artifactory/deb $(awk -F= '/^VERSION_CODENAME/{print$2}' /etc/os-release) main\" | tee /etc/apt/sources.list.d/adoptium.list      && apt-get update 
      && apt-get -y dist-upgrade      && apt-get -y install temurin-17-jdk' returned a non-zero code: 100" ]
   ```
   
   The command I run: `UBUNTU_MIRROR=http://archive.ubuntu.com/ubuntu/ ./build/build_java_test_image.sh`
   </details>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on a diff in pull request #17129: [improve][docker] Switch to Temurin JDK

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17129:
URL: https://github.com/apache/pulsar/pull/17129#discussion_r948602287


##########
docker/pulsar/Dockerfile:
##########
@@ -76,8 +86,8 @@ RUN pip3 install pyyaml==5.4.1
 # 4. /pulsar - hadoop writes to this directory
 RUN mkdir /pulsar && chmod g+w /pulsar
 
-ENV JAVA_HOME /usr/lib/jvm/java-17-openjdk-amd64
-RUN echo networkaddress.cache.ttl=1 >> /usr/lib/jvm/java-17-openjdk-amd64/conf/security/java.security
+ENV JAVA_HOME /usr/lib/jvm/temurin-17-jdk-amd64
+RUN echo networkaddress.cache.ttl=1 >> /usr/lib/jvm/temurin-17-jdk-amd64/conf/security/java.security

Review Comment:
   Before this change, when I build on M1 with `Docker version 20.10.17, build 100c701`, it failed with:
   
   ```
   [INFO] DOCKER> Step 14/25 : ENV JAVA_HOME /usr/lib/jvm/java-17-openjdk-amd64
   [INFO] DOCKER> 
   [INFO] DOCKER> ---> Running in a47a209de148
   [INFO] DOCKER> Removing intermediate container a47a209de148
   [INFO] DOCKER> ---> 6a9d5c8543b8
   [INFO] DOCKER> Step 15/25 : RUN echo networkaddress.cache.ttl=1 >> /usr/lib/jvm/java-17-openjdk-amd64/conf/security/java.security
   [INFO] DOCKER> 
   [INFO] DOCKER> ---> Running in d55c15e90ed1
   [INFO] DOCKER> [91m/bin/sh: 1: cannot create /usr/lib/jvm/java-17-openjdk-amd64/conf/security/java.security: Directory nonexistent
   
   [INFO] DOCKER> Removing intermediate container d55c15e90ed1
   [ERROR] DOCKER> Unable to build image [apachepulsar/java-test-image] : "The command '/bin/sh -c echo networkaddress.cache.ttl=1 >> /usr/lib/jvm/java-17-openjdk-amd64/conf/security/java.security' returned a non-zero code: 2"  ["The command '/bin/sh -c echo networkaddress.cache.ttl=1 >> /usr/lib/jvm/java-17-openjdk-amd64/conf/security/java.security' returned a non-zero code: 2" ]
   ```
   
   Perhaps it's unrelated to this patch. Just throw here by any chances we may `mkdir -p` before `echo`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece commented on a diff in pull request #17129: [improve][docker] Switch to Temurin JDK

Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #17129:
URL: https://github.com/apache/pulsar/pull/17129#discussion_r948613583


##########
docker/pulsar/Dockerfile:
##########
@@ -76,8 +86,8 @@ RUN pip3 install pyyaml==5.4.1
 # 4. /pulsar - hadoop writes to this directory
 RUN mkdir /pulsar && chmod g+w /pulsar
 
-ENV JAVA_HOME /usr/lib/jvm/java-17-openjdk-amd64
-RUN echo networkaddress.cache.ttl=1 >> /usr/lib/jvm/java-17-openjdk-amd64/conf/security/java.security
+ENV JAVA_HOME /usr/lib/jvm/temurin-17-jdk-amd64
+RUN echo networkaddress.cache.ttl=1 >> /usr/lib/jvm/temurin-17-jdk-amd64/conf/security/java.security

Review Comment:
   Could you try using the Temurin JDK on the M1?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] mattisonchao commented on pull request #17129: [improve][docker] Switch to Temurin JDK

Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #17129:
URL: https://github.com/apache/pulsar/pull/17129#issuecomment-1223668174

   Question: 
   Do we have some compatible issues with two different JDKs?
   I wonder if it will affect some users who use old JDK and upgrade with new JDK.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on pull request #17129: [improve][docker] Switch to Temurin JDK

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17129:
URL: https://github.com/apache/pulsar/pull/17129#issuecomment-1232373587

   @nodece Yep. Not a requirement for this patch, just for your information :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece merged pull request #17129: [improve][docker] Switch to Temurin JDK

Posted by GitBox <gi...@apache.org>.
nodece merged PR #17129:
URL: https://github.com/apache/pulsar/pull/17129


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on a diff in pull request #17129: [improve][docker] Switch to Temurin JDK

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17129:
URL: https://github.com/apache/pulsar/pull/17129#discussion_r975204999


##########
docker/pulsar/Dockerfile:
##########
@@ -58,10 +58,20 @@ RUN sed -i "s|http://archive\.ubuntu\.com/ubuntu/|${UBUNTU_MIRROR:-mirror://mirr
      && echo 'Acquire::http::Timeout "30";\nAcquire::ftp::Timeout "30";\nAcquire::Retries "3";' > /etc/apt/apt.conf.d/99timeout_and_retries \
      && apt-get update \
      && apt-get -y dist-upgrade \
-     && apt-get -y install --no-install-recommends openjdk-17-jdk-headless netcat dnsutils less procps iputils-ping \
+     && apt-get -y install --no-install-recommends netcat dnsutils less procps iputils-ping \
                  python3 python3-kazoo python3-pip \
-                 curl ca-certificates \
-     && apt-get -y --purge autoremove \
+                 curl ca-certificates wget apt-transport-https
+
+# Install Eclipse Temurin Package
+RUN mkdir -p /etc/apt/keyrings \
+     && wget -O - https://packages.adoptium.net/artifactory/api/gpg/key/public | tee /etc/apt/keyrings/adoptium.asc \
+     && echo "deb [signed-by=/etc/apt/keyrings/adoptium.asc] https://packages.adoptium.net/artifactory/deb $(awk -F= '/^VERSION_CODENAME/{print$2}' /etc/os-release) main" | tee /etc/apt/sources.list.d/adoptium.list \
+     && apt-get update \
+     && apt-get -y dist-upgrade \
+     && apt-get -y install temurin-17-jdk
+
+# Cleanup apt
+RUN apt-get -y --purge autoremove \

Review Comment:
   Revert as if I perform this command merge, the build will fail with `returned a non-zero code: 100`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org