[jira] [Commented] (PHOENIX-3515) CsvLineParser Improvement

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15714579#comment-15714579 ] 

Hadoop QA commented on PHOENIX-3515:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12841425/PHOENIX-3515.1.patch
  against master branch at commit 683e1f0fe8f61e6c01f766a9d25ca3e953691464.
  ATTACHMENT ID: 12841425

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 44 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

     {color:red}-1 core zombie tests{color}.  There are 3 zombie test(s): 	at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFailure(TestExportSnapshot.java:249)
	at org.apache.hadoop.hbase.client.TestReplicasClient.testCancelOfScan(TestReplicasClient.java:632)
	at org.apache.hadoop.hbase.master.balancer.BalancerTestBase.testWithCluster(BalancerTestBase.java:623)
	at org.apache.hadoop.hbase.master.balancer.BalancerTestBase.testWithCluster(BalancerTestBase.java:613)
	at org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2.testRegionReplicasOnMidCluster(TestStochasticLoadBalancer2.java:57)

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/693//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/693//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/693//console

This message is automatically generated.

> CsvLineParser Improvement
> -------------------------
>
>                 Key: PHOENIX-3515
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3515
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Jeongdae Kim
>            Assignee: Jeongdae Kim
>            Priority: Minor
>         Attachments: PHOENIX-3515.1.patch
>
>
> CsvLineParser creates a new parser(apache commons CSVParser) every single line. it seems terribly inefficient.
> I improved this issue by adding a new string reader to a parser once and use this for all lines.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)