[GitHub] tysonnorris commented on issue #3562: ArtifactStore implementation for CosmosDB

[GitBox <gi...@apache.org>]

tysonnorris commented on issue #3562: ArtifactStore implementation for CosmosDB
URL: https://github.com/apache/incubator-openwhisk/pull/3562#issuecomment-390362929
 
 
   This seems good to me, would like some others to chime in. My questions are mainly around:
   - client connection sharing across ArtifactStores (can we just create separate connections?)
   - multiple stores currently getting created (is there any risk?)
   
   On this last one, I think it is a defect of `WhiskStore` that multiple calls to `WhiskEntityStore.datastore()` will return multiple unique instances - I think these should return the same instance (invoke `makeStore[WhiskEntity]()` once ever). I don't know if it impacts cosmos (client is shared with multiple separate instances of the same store?), but if so, maybe we can fix it here? otherwise can fix it separately.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services