You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2012/09/04 21:59:01 UTC
svn commit: r1380832 - in /jmeter/trunk/src/core/org/apache/jmeter/gui:
AbstractJMeterGuiComponent.java LoggerPanel.java NamePanel.java
Author: pmouawad
Date: Tue Sep 4 19:59:01 2012
New Revision: 1380832
URL: http://svn.apache.org/viewvc?rev=1380832&view=rev
Log:
Make fields final
Make some variables local
Modified:
jmeter/trunk/src/core/org/apache/jmeter/gui/AbstractJMeterGuiComponent.java
jmeter/trunk/src/core/org/apache/jmeter/gui/LoggerPanel.java
jmeter/trunk/src/core/org/apache/jmeter/gui/NamePanel.java
Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/AbstractJMeterGuiComponent.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/gui/AbstractJMeterGuiComponent.java?rev=1380832&r1=1380831&r2=1380832&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/gui/AbstractJMeterGuiComponent.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/gui/AbstractJMeterGuiComponent.java Tue Sep 4 19:59:01 2012
@@ -69,7 +69,7 @@ public abstract class AbstractJMeterGuiC
protected NamePanel namePanel;
// used by AbstractReportGui
- private CommentPanel commentPanel;
+ private final CommentPanel commentPanel;
/**
* When constructing a new component, this takes care of basic tasks like
Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/LoggerPanel.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/gui/LoggerPanel.java?rev=1380832&r1=1380831&r2=1380832&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/gui/LoggerPanel.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/gui/LoggerPanel.java Tue Sep 4 19:59:01 2012
@@ -42,7 +42,7 @@ public class LoggerPanel extends JPanel
private JTextArea textArea;
- private PatternFormatter format;
+ private final PatternFormatter format;
// Limit length of log content
private static final int LOGGER_PANEL_MAX_LENGTH =
Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/NamePanel.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/gui/NamePanel.java?rev=1380832&r1=1380831&r2=1380832&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/gui/NamePanel.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/gui/NamePanel.java Tue Sep 4 19:59:01 2012
@@ -35,10 +35,8 @@ public class NamePanel extends JPanel im
private static final long serialVersionUID = 240L;
/** A text field containing the name. */
- private JTextField nameField = new JTextField(15);
+ private final JTextField nameField = new JTextField(15);
- /** The label for the text field. */
- private JLabel nameLabel;
/**
* Create a new NamePanel with the default name.
@@ -53,8 +51,8 @@ public class NamePanel extends JPanel im
*/
private void init() {
setLayout(new BorderLayout(5, 0));
-
- nameLabel = new JLabel(JMeterUtils.getResString("name")); // $NON-NLS-1$
+ /** The label for the text field. */
+ JLabel nameLabel = new JLabel(JMeterUtils.getResString("name")); // $NON-NLS-1$
nameLabel.setName("name");
nameLabel.setLabelFor(nameField);