You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/02/05 16:23:11 UTC
[GitHub] [accumulo] brianloss commented on a change in pull request #1912: Rename master comment/constant/variable references.
brianloss commented on a change in pull request #1912:
URL: https://github.com/apache/accumulo/pull/1912#discussion_r571087563
##########
File path: core/src/main/java/org/apache/accumulo/core/Constants.java
##########
@@ -42,11 +42,11 @@
public static final String ZNAMESPACE_NAME = "/name";
public static final String ZNAMESPACE_CONF = "/conf";
- public static final String ZMASTERS = "/masters";
- public static final String ZMASTER_LOCK = ZMASTERS + "/lock";
- public static final String ZMASTER_GOAL_STATE = ZMASTERS + "/goal_state";
- public static final String ZMASTER_REPLICATION_COORDINATOR_ADDR = ZMASTERS + "/repl_coord_addr";
- public static final String ZMASTER_TICK = ZMASTERS + "/tick";
+ public static final String ZMANAGERS = "/masters";
Review comment:
I didn't rename the ZK dir to "managers" because that prevents the manager from starting without initialization. It seemed like too much for a minor release to require a user run some fixup script before launching 2.1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org