You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@issues.apache.org on 2010/04/16 17:56:23 UTC
[Bug 6413] New: sa-learn can't parse mbox of latest CommuniGate Pro
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6413
Summary: sa-learn can't parse mbox of latest CommuniGate Pro
Product: Spamassassin
Version: 3.3.1
Platform: PC
OS/Version: FreeBSD
Status: NEW
Severity: major
Priority: P2
Component: Learner
AssignedTo: dev@spamassassin.apache.org
ReportedBy: redrat@mail.ru
Created an attachment (id=4742)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4742)
Message in the new mbox format.
First of all, excuse my English.
In the recent versions of Communigate Pro was changed format of date in the
From_ line. Old was like "From <>(________-000000000007) Wed Feb 20 20:28:23
2008", and new is like "From <>(S_____________-000000085573)
16-04-2010_08:55:34_". Because of it sa-learn can't parse CGP's mbox anymore,
and users got "Learned tokens from 0 message(s) (0 message(s) examined)"
message.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6413] sa-learn can't parse mbox of latest CommuniGate Pro
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6413
--- Comment #2 from Kevin A. McGrail <km...@pccc.com> 2011-10-29 02:41:05 UTC ---
Created attachment 4995
--> https://issues.apache.org/SpamAssassin/attachment.cgi?id=4995
Patch to change ArchiveIterator to also pick up Communigates Mbox format
Since the mbox format is very very unspecified (see
http://tools.ietf.org/html/rfc4155), expanding this a bit makes sense in a way.
However, changing the code as proposed in the PoC might break things for other
users. You were very clear it was just a proof of concept.
So I took your PoC and change it to a case in ArchiveIterator.pm that handles
both the existing and Communigate's format through the regex you provided.
It appears to work. I've tested with your example and an mbox file from mutt
via sendmail and procmail and believe it works interchangeably.
I will commit and would appreciate your feedback.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6413] sa-learn can't parse mbox of latest CommuniGate Pro
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6413
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |kmcgrail@pccc.com
Resolution| |FIXED
--- Comment #3 from Kevin A. McGrail <km...@pccc.com> 2011-10-29 02:41:16 UTC ---
svn commit -m 'extension of From: boundary check for Communigate Pro Bug 6413'
Sending lib/Mail/SpamAssassin/ArchiveIterator.pm
Transmitting file data .
Committed revision 1190742.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6413] sa-learn can't parse mbox of latest CommuniGate Pro
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6413
--- Comment #1 from Alexey Markov <re...@mail.ru> 2010-04-19 09:09:48 EDT ---
Created an attachment (id=4748)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4748)
Just proof of concept
It's not a real patch but rather a proof of concept. After applying this patch
my sa-learn can work with a new format of mbox in the recent Communigate Pro
versions (5.2.x and later).
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6413] sa-learn can't parse mbox of latest CommuniGate Pro
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6413
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.3.2
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6413] sa-learn can't parse mbox of latest CommuniGate Pro
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6413
Alexey Markov <re...@mail.ru> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |redrat@mail.ru
--- Comment #4 from Alexey Markov <re...@mail.ru> 2011-10-31 06:11:52 UTC ---
(In reply to comment #2)
> It appears to work. I've tested with your example and an mbox file from mutt
> via sendmail and procmail and believe it works interchangeably.
> I will commit and would appreciate your feedback.
I have tested your patch on my production CommuniGate Pro mail server and it
works fine. Thanks a lot for your work, Kevin!
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.