You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xtable.apache.org by "oringnam (via GitHub)" <gi...@apache.org> on 2025/06/12 05:16:00 UTC

[I] Demo Notebook Fails on `main` branch: Build-Artifact Mismatch & API Drift [incubator-xtable]

oringnam opened a new issue, #727:
URL: https://github.com/apache/incubator-xtable/issues/727

   ### Search before asking
   
   - [x] I had searched in the [issues](https://github.com/apache/incubator-xtable/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Please describe the bug 🐞
   
    # Summary
    The example notebook / script shipped with Apache Xtable no longer runs on the current `main` branch.  
    Execution fails for three independent reasons:
    
    1. an incorrect JAR coordinate,
    2. an outdated method invocation, and
    3. the removal of an internal configuration class.
    
    # Details
    1. Incorrect core-JAR coordinate
    ```xml
    <artifactId>xtable-core_${scala.binary.version}</artifactId>
    ```
    The demo expects a module called xtable-core, but the artifact actually published to Maven Central is xtable-core_${scala.binary.version}.
    Because the script loads the wrong coordinate, it cannot find core classes at runtime.
    
    2. Extra argument in HudiConversionSourceProvider.init
    ```scala
    hudiConversionSourceProvider.init(
        spark.sparkContext.hadoopConfiguration,
        Collections.emptyMap()   // <-- deprecated
    )
    ```
    
    init now accepts only a single Configuration parameter.
    Passing the second argument produces:
    ```
    cmd3.sc:19: too many arguments (2) for method init: (x$1: org.apache.hadoop.conf.Configuration)Unit
    ```
    
    3. PerTableConfigImpl removed (PR #480)
    The demo still references PerTableConfigImpl, which was deleted in PR #480.
    ```
    cmd3.sc:10: not found: value PerTableConfigImpl
    ```
    The recommended pattern is to build a ConversionConfig and a list of TargetTable instances instead.
    
    # Proposed Fix
    - Update the POM line to xtable-core_${scala.binary.version} or the demo scripts.
    - Remove the second argument from HudiConversionSourceProvider.init(...).
    - Replace PerTableConfigImpl with the new ConversionConfig + TargetTable builder API in the demo.
   
   ### Are you willing to submit PR?
   
   - [x] I am willing to submit a PR!
   - [ ] I am willing to submit a PR but need help getting started!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Demo Notebook Fails on `main` branch: Build-Artifact Mismatch & API Drift [incubator-xtable]

Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 closed issue #727: Demo Notebook Fails on `main` branch: Build-Artifact Mismatch & API Drift
URL: https://github.com/apache/incubator-xtable/issues/727


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Demo Notebook Fails on `main` branch: Build-Artifact Mismatch & API Drift [incubator-xtable]

Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 commented on issue #727:
URL: https://github.com/apache/incubator-xtable/issues/727#issuecomment-2968038269

   I can take care of it as well, but let me know either way. Thought this might be a good opportunity for your first contribution. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Demo Notebook Fails on `main` branch: Build-Artifact Mismatch & API Drift [incubator-xtable]

Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 commented on issue #727:
URL: https://github.com/apache/incubator-xtable/issues/727#issuecomment-2967879904

   Thanks for reporting the bug @oringnam are you planning to put up a PR or need help in getting started? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Demo Notebook Fails on `main` branch: Build-Artifact Mismatch & API Drift [incubator-xtable]

Posted by "lsyulong (via GitHub)" <gi...@apache.org>.
lsyulong commented on issue #727:
URL: https://github.com/apache/incubator-xtable/issues/727#issuecomment-3138819854

   hi @vinishjail97 I am new to this project, but I still want to study it. Can you give me some help on how to fix and verify this problem? I will develop on Windows and test and verify on Linux.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org