You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/18 03:32:49 UTC

[GitHub] [apisix] tzssangglass commented on a change in pull request #6600: feat: support for having port in host header when pass_host = node and port is not standard

tzssangglass commented on a change in pull request #6600:
URL: https://github.com/apache/apisix/pull/6600#discussion_r829669250



##########
File path: apisix/balancer.lua
##########
@@ -176,6 +177,17 @@ local function set_balancer_opts(route, ctx)
 end
 
 
+local function parse_server_for_upstream_host(picked_server, ctx)
+    local upstream_scheme = ctx.upstream_scheme
+    local standard_port = apisix_upstream.scheme_to_port[upstream_scheme]

Review comment:
       ```suggestion
   local function parse_server_for_upstream_host(picked_server, upstream_scheme)
       local standard_port = apisix_upstream.scheme_to_port[upstream_scheme]
   ```
   
   is better?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org