You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/22 17:38:51 UTC
[GitHub] squito commented on issue #23688: [SPARK-25035][Core] Avoiding
memory mapping at disk-stored blocks replication
squito commented on issue #23688: [SPARK-25035][Core] Avoiding memory mapping at disk-stored blocks replication
URL: https://github.com/apache/spark/pull/23688#issuecomment-466481233
lgtm, thanks for the extra tests @attilapiros
I'm about to travel for a week, and dont' want to make a change to such a core part of spark before that, so I'm not going to merge it now. either someone else can merge, or it can wait till I'm back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org