[jira] Commented: (CXF-2596) Default logging in interceptor chain may pollute the log with stacktrace from application exceptions that are a part of the normal flow (should not be logged).

["Sergey Beryozkin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795278#action_12795278 ] 

Sergey Beryozkin commented on CXF-2596:
---------------------------------------

Hi,

The patch looks really fine, thanks.  Just wondering, would it make sense to pass a message to a fault logger too, perhaps for it to be able to check the fault mode, or some other info available from the exchange ?

Another thing to consider : would it make sense to indicate to PhaseInterceptorChain that the default fault logging should go ahead after a fault logger has tried to log ? Otherwise a fault logger may also need to do what the default fault logging already does ? Returning a boolean flag is a possible solution but may be there' s a better solution, provided you agree that it is worth addressing it ?

cheers, Sergey

> Default logging in interceptor chain may pollute the log with stacktrace from application exceptions that are a part of the normal flow (should not be logged).
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CXF-2596
>                 URL: https://issues.apache.org/jira/browse/CXF-2596
>             Project: CXF
>          Issue Type: New Feature
>          Components: Configuration
>         Environment: All
>            Reporter: Tomas Majak
>         Attachments: custom_logging_in_interceptorchain.patch
>
>
> A user of CXF may need custom handling for runtime errors produced by the application, not catchable within the application, e.g. exceptions from interceptors to the actual service.
> E.g. applications may produce Exceptions that are a normal part of the flow in the application, in that case, it pollutes the log file to have it logged as stacktrace. 
> background: http://www.mail-archive.com/users@cxf.apache.org/msg10976.html
> Configure via setting property to Bus or Service:
>  <property name="org.apache.cxf.logging.FaultLogger">
>        <bean class="com.foo.MyFaultLogger"/>
>    </property>
> MyFaultLogger must implement org.apache.cxf.logging.FaultLogger
> Programatically:
> Bus bean = (Bus) applicationContext.getBean("cxf");
> bean.setProperty("org.apache.cxf.logging.FaultLogger", myLogger);
> By endpoint:
> <jaxws:endpoint id="mySericeWS" implementor="#myServiceBean" address="/myServiceWS">
>   <jaxws:properties>
>     <entry key="org.apache.cxf.logging.FaultLogger">
>       <bean class="com.foo.MyFaultLogger"/>
>     </entry>
>   </jaxws:properties>
> </jaxws:endpoint>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.