You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@graphar.apache.org by "SemyonSinchenko (via GitHub)" <gi...@apache.org> on 2025/03/04 07:40:41 UTC
[I] feat(java): provide additional methods in java info [incubator-graphar]
SemyonSinchenko opened a new issue, #667:
URL: https://github.com/apache/incubator-graphar/issues/667
### Describe the enhancement requested
At least we should override `equals()`, `toString()` and `hashCode`. It is nice to have also methods that checks is a property group in the info and methods for getting a property group by its type. These methods are important because the underlying collections are private members of info classes and the end user cannot call them.
### Component(s)
Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [I] feat(java): provide additional methods in java info [incubator-graphar]
Posted by "Thespica (via GitHub)" <gi...@apache.org>.
Thespica commented on issue #667:
URL: https://github.com/apache/incubator-graphar/issues/667#issuecomment-2697321974
VertexInfo and EdgeInfo can check if a PropertyGroup is in the info:
https://github.com/apache/incubator-graphar/blob/0bf48c1f4a254a06ced3dff1f5c116272bb4b11a/maven-projects/info/src/main/java/org/apache/graphar/info/VertexInfo.java#L95-L97
https://github.com/apache/incubator-graphar/blob/0bf48c1f4a254a06ced3dff1f5c116272bb4b11a/maven-projects/info/src/main/java/org/apache/graphar/info/EdgeInfo.java#L142-L144
And we can also get a PropertyGroup by type of a Propery which is in this PG in an EdgeInfo(yes, VertexInfo seems missed that method. Maybe this function should be called `getBelongedPropertyGroup`?):
https://github.com/apache/incubator-graphar/blob/0bf48c1f4a254a06ced3dff1f5c116272bb4b11a/maven-projects/info/src/main/java/org/apache/graphar/info/EdgeInfo.java#L158-L160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [I] feat(java): provide additional methods in java info [incubator-graphar]
Posted by "Thespica (via GitHub)" <gi...@apache.org>.
Thespica commented on issue #667:
URL: https://github.com/apache/incubator-graphar/issues/667#issuecomment-2700839058
> I will open a PR with `equals`, `toString` and `hashCode` only.
Beyond this, you can add the missed method `getPropertyGroup` to VertexInfo. Maybe rename it to `getBelongedPropertyGroup` for VertexInfo and EdgeInfo will be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [I] feat(java): provide additional methods in java info [incubator-graphar]
Posted by "SemyonSinchenko (via GitHub)" <gi...@apache.org>.
SemyonSinchenko commented on issue #667:
URL: https://github.com/apache/incubator-graphar/issues/667#issuecomment-2697329874
I was trying to map existing spark infos to the new java info and realized that some methods are missing, but it looks like they are just named differently. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [I] feat(java): provide additional methods in java info [incubator-graphar]
Posted by "SemyonSinchenko (via GitHub)" <gi...@apache.org>.
SemyonSinchenko commented on issue #667:
URL: https://github.com/apache/incubator-graphar/issues/667#issuecomment-2697393982
I will open a PR with `equals`, `toString` and `hashCode` only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org