You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/17 15:33:36 UTC
[GitHub] [airflow] robinhur opened a new issue #11618: Support to turn off the sql echo at logging in dbapi_hook
robinhur opened a new issue #11618:
URL: https://github.com/apache/airflow/issues/11618
**Description**
through the parameter, like `mute=True`,
can turn off not to echo the SQL query
**Use case / motivation**
I hope we can turn on or off the option to echo or not echo of SQL query
First, if the query is too long, the log becomes unnecessarily heavy
And also sometimes we don't want it to be recorded because of like privacy issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #11618: Support to turn off the sql echo at logging in dbapi_hook
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #11618:
URL: https://github.com/apache/airflow/issues/11618#issuecomment-739994895
I removed the milestone because this looks like a change that we can do later, and now we don't have any person assigned to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ChrisWeinrich commented on issue #11618: Support to turn off the sql echo at logging in dbapi_hook
Posted by GitBox <gi...@apache.org>.
ChrisWeinrich commented on issue #11618:
URL: https://github.com/apache/airflow/issues/11618#issuecomment-967132070
Is therey any work going on here or someone knows a workarround ? We have ~10k * 500 Insert Lines and this spams the logging very badly :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #11618: Support to turn off the sql echo at logging in dbapi_hook
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #11618:
URL: https://github.com/apache/airflow/issues/11618#issuecomment-739787180
Is this somethign we should inclue in 2.0 @mik-laj ? WDYT? Shall we remove the milestone from it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #11618: Support to turn off the sql echo at logging in dbapi_hook
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #11618:
URL: https://github.com/apache/airflow/issues/11618#issuecomment-712132437
Related: https://github.com/apache/airflow/pull/9671
CC: @kaxil @davido912 @madison-ookla
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #11618: Support to turn off the sql echo at logging in dbapi_hook
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #11618:
URL: https://github.com/apache/airflow/issues/11618#issuecomment-711030658
Thanks for opening your first issue here! Be sure to follow the issue template!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #11618: Support to turn off the sql echo at logging in dbapi_hook
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #11618:
URL: https://github.com/apache/airflow/issues/11618#issuecomment-967203906
Start here: https://github.com/apache/airflow/blob/main/CONTRIBUTORS_QUICK_START.rst , detailed contributor's guide is at https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst and if you like video tutorials - here is a recording of the first-time contributor's workshop we held during OCSS Mexico: https://youtu.be/kvccZizzfTk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] robinhur commented on issue #11618: Support to turn off the sql echo at logging in dbapi_hook
Posted by GitBox <gi...@apache.org>.
robinhur commented on issue #11618:
URL: https://github.com/apache/airflow/issues/11618#issuecomment-967201666
@potiuk
yes please
will take a look and create PR for this when i have a chance
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #11618: Support to turn off the sql echo at logging in dbapi_hook
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #11618:
URL: https://github.com/apache/airflow/issues/11618#issuecomment-967734317
Yup, just add a feature to add `log_sql` kwarg to `DbApiHook` and then https://github.com/apache/airflow/pull/18718 should help in passing this kwargs to hook so that we don't need to add it to all Operators or just `BaseSQLOperator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on issue #11618: Support to turn off the sql echo at logging in dbapi_hook
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on issue #11618:
URL: https://github.com/apache/airflow/issues/11618#issuecomment-967734317
Yup, just add a feature to add `log_sql` kwarg to `DbApiHook` and then https://github.com/apache/airflow/pull/18718 should help in passing this kwargs to hook so that we don't need to add it to all Operators or just `BaseSQLOperator`
cc @denimalpaca
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #11618: Support to turn off the sql echo at logging in dbapi_hook
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #11618:
URL: https://github.com/apache/airflow/issues/11618#issuecomment-967203906
Start here: https://github.com/apache/airflow/blob/main/CONTRIBUTORS_QUICK_START.rst , detailed contributor's guide is at https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst and if you like video tutorials - here is a recording for first-time contributor's workshop we held during OCSS Mexico: https://youtu.be/kvccZizzfTk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #11618: Support to turn off the sql echo at logging in dbapi_hook
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #11618:
URL: https://github.com/apache/airflow/issues/11618#issuecomment-967200633
@robinhur @ChrisWeinrich - the easiest and most certain way to get this implement is to submit a PR with a fix. Airflow is developed by > 1800 contributors, and there is no magical "someone's approval" to provide a fix for such a simple PR.
It's really as simple as it gets - the person most interested in a feature/fix usually implements it. Waiting a year makes very little sense if you can provide PR in an hour and get it merged in a few days after review.
Do you need any guidance on preparing a PR for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #11618: Support to turn off the sql echo at logging in dbapi_hook
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #11618:
URL: https://github.com/apache/airflow/issues/11618#issuecomment-967200633
@robinhur @ChrisWeinrich - the easiest and most certain way to get this implement is to submit a PR with a fix. Airflow is developed by > 1800 contributors, and there is no magical "someone's approval" to provide a fix for such a simple issue.
It's really as simple as it gets - the person most interested in a feature/fix usually implements it. Waiting a year makes very little sense if you can provide PR in an hour and get it merged in a few days later - after review and corrections.
Do you need any guidance on preparing a PR for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] robinhur commented on issue #11618: Support to turn off the sql echo at logging in dbapi_hook
Posted by GitBox <gi...@apache.org>.
robinhur commented on issue #11618:
URL: https://github.com/apache/airflow/issues/11618#issuecomment-967187984
@ChrisWeinrich
it's been almost an yr for me to raise this issue
and i've resolved it by creating my own operator that overrides existing codes and added to skip the echo part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #11618: Support to turn off the sql echo at logging in dbapi_hook
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #11618:
URL: https://github.com/apache/airflow/issues/11618#issuecomment-967200633
@robinhur @ChrisWeinrich - the easiest and most certain way to get this implement is to submit a PR with a fix. Airflow is developed by > 1800 contributors, and there is no magical "someone's approval" to provide a fix for such a simple issue.
It's really as simple as it gets - the person most interested in a feature/fix usually implements it. Waiting a year makes very little sense if you can provide PR in an hour and get it merged in a few days after review.
Do you need any guidance on preparing a PR for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] robinhur commented on issue #11618: Support to turn off the sql echo at logging in dbapi_hook
Posted by GitBox <gi...@apache.org>.
robinhur commented on issue #11618:
URL: https://github.com/apache/airflow/issues/11618#issuecomment-967205196
@potiuk Great Information!!
@ChrisWeinrich wait for it!! will let you have this feature soon :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org