You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/02/15 19:56:44 UTC
[GitHub] [couchdb] nickva opened a new pull request #3931: Fix flaky collator auto-upgrade test
nickva opened a new pull request #3931:
URL: https://github.com/apache/couchdb/pull/3931
Couldn't reproduce flakiness locally but it failed in CI at least twice.
Try to extend the wait timeout and poll frequency, and set `commit_freq = 0` for some tests.
Thanks to @noahshaw11 for pointing out the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jaydoane commented on a change in pull request #3931: Fix flaky collator auto-upgrade test
Posted by GitBox <gi...@apache.org>.
jaydoane commented on a change in pull request #3931:
URL: https://github.com/apache/couchdb/pull/3931#discussion_r807268918
##########
File path: src/couch/test/eunit/couchdb_views_tests.erl
##########
@@ -474,6 +475,7 @@ can_update_views_with_old_collators({_, {DbName, Files}}) ->
view_collator_auto_upgrade_on_open({_, {DbName, Files}}) ->
?_test(begin
[_NewDbFilePath, ViewFilePath, ViewFilePath] = Files,
+ ok = config:set("query_server_config", "commit_freq", "0", false),
Review comment:
Should this setting be deleted after the test has run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva merged pull request #3931: Fix flaky collator auto-upgrade test
Posted by GitBox <gi...@apache.org>.
nickva merged pull request #3931:
URL: https://github.com/apache/couchdb/pull/3931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on a change in pull request #3931: Fix flaky collator auto-upgrade test
Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #3931:
URL: https://github.com/apache/couchdb/pull/3931#discussion_r807275197
##########
File path: src/couch/test/eunit/couchdb_views_tests.erl
##########
@@ -474,6 +475,7 @@ can_update_views_with_old_collators({_, {DbName, Files}}) ->
view_collator_auto_upgrade_on_open({_, {DbName, Files}}) ->
?_test(begin
[_NewDbFilePath, ViewFilePath, ViewFilePath] = Files,
+ ok = config:set("query_server_config", "commit_freq", "0", false),
Review comment:
For this particular set of tests technically not as important as it's set in memory only (doesn't get written) and on every test we restart all the couch apps including couch config since they run in a `foreach` test group https://github.com/apache/couchdb/blob/4bcbf1fd649f6e556fab069487aa96fad1c031e9/src/couch/test/eunit/couchdb_views_tests.erl#L250-L258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org