You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/19 09:31:01 UTC

[GitHub] [inlong] woofyzhao commented on a diff in pull request #5519: [INLONG-4973][Manager] Supplement the Managerctl Commands Tools

woofyzhao commented on code in PR #5519:
URL: https://github.com/apache/inlong/pull/5519#discussion_r950002013


##########
inlong-manager/manager-client-tools/src/main/java/org/apache/inlong/manager/client/cli/CreateCommand.java:
##########
@@ -51,26 +51,38 @@ private static class CreateGroup extends AbstractCommandRunner {
 
         @Parameter(names = {"-f", "--file"},
                 converter = FileConverter.class,
-                required = true,
                 description = "json file")
         private File file;
 
+        //TODO:add gdbc connector and others

Review Comment:
   Suggest leave a blank between start of comment // and _text_ which is the case in all other inlong source files. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org