Re: [PR] refactor: Upgrade to React 17 [superset]

["kgabryje (via GitHub)" <gi...@apache.org>]

kgabryje commented on PR #31961:
URL: https://github.com/apache/superset/pull/31961#issuecomment-2610007240

   Status update:
   While the project builds and runs just fine, there are multiple problems with the unit tests. For some reason Jest runtime environment triggers many errors that don't happen in regular runtime, such as problems with default exports (converting to a named export fixes the error, but I can't see a pattern - not all default errors are failing), problems with `jest.spyOn` (again - only some cases trigger an error, such as spying on superset-ui/core), errors like `Cannot read properties of undefined (reading 'window')` and many more. Overall over a 100 tests are failing right now.
   I'm still trying to fix the jest and babel configs so that we don't need to manually adjust those tests. I've had limited luck so far (initially all tests were failing so I call it a success that at least some are passing now 😛) and GTP/Claude/Stackoverflow have not been very helpful. If I can't fix the tests with proper configuration, we'll need to do some code adjustments, not only in the tests, but the components too (for example converting problematic default exports to named ones).
   CC @villebro @eschutho @mistercrunch @michael-s-molina 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org