[GitHub] [spark] HeartSaVioR edited a comment on pull request #29011: [WIP][SPARK-XXXXX][SQL] Parallelize HashAggregationQueryWithControlledFallbackSuite

[GitBox <gi...@apache.org>]

HeartSaVioR edited a comment on pull request #29011:
URL: https://github.com/apache/spark/pull/29011#issuecomment-654170747


   Rationalization: it turns out that HashAggregationQueryWithFallbackSuite is more than 11x slower compared to HashAggregationQuerySuite. (It ran same test with 12 different configs)
   
   If the test ran fast enough then the elapsed time of HashAggregationQueryWithFallbackSuite is acceptable, but sometimes the test ran slow, and HashAggregationQueryWithFallbackSuite took more than 11x even for the case (I saw 10mins ~ 1hr+ for the suite).
   
   This WIP patch tries to parallelize tests via creating suite per config. Setting UnsafeAlignedOffset size affects globally, hence it's excluded from the matrix. (Hence 6 suites.)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org