You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by hn...@apache.org on 2019/10/28 16:09:31 UTC

[myfaces-tobago] branch master updated: fix checked SelectManyCheckbox with ajax

This is an automated email from the ASF dual-hosted git repository.

hnoeth pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git


The following commit(s) were added to refs/heads/master by this push:
     new 11ed9d5  fix checked SelectManyCheckbox with ajax
11ed9d5 is described below

commit 11ed9d54fa776ba483858fa3c0c8da45a74d768a
Author: Henning Noeth <hn...@apache.org>
AuthorDate: Mon Oct 28 17:09:20 2019 +0100

    fix checked SelectManyCheckbox with ajax
    
    The checked-symbol doesn't appear if SelectManyCheckbox is used with
    ajax.
    
    The CSS expects the I-element after the input-element.
    The order is now rearranged. Now it's: input, I-Element, behavior.
    
    issue: TOBAGO-1633: TS refactoring
---
 .../internal/renderkit/renderer/SelectManyCheckboxRenderer.java       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyCheckboxRenderer.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyCheckboxRenderer.java
index ec960f3..3af82f7 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyCheckboxRenderer.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyCheckboxRenderer.java
@@ -115,12 +115,12 @@ public class SelectManyCheckboxRenderer extends SelectManyRendererBase {
         writer.writeAttribute(HtmlAttributes.TABINDEX, select.getTabIndex());
         writer.endElement(HtmlElements.INPUT);
 
-        encodeBehavior(writer, facesContext, select);
-
         writer.startElement(HtmlElements.I);
         writer.writeClassAttribute(TobagoClass.INPUT_PSEUDO);
         writer.endElement(HtmlElements.I);
 
+        encodeBehavior(writer, facesContext, select);
+
         if (item instanceof org.apache.myfaces.tobago.model.SelectItem) {
           final org.apache.myfaces.tobago.model.SelectItem tobagoItem =
               (org.apache.myfaces.tobago.model.SelectItem) item;